Page MenuHomePhabricator
Differential D5804

[lib] introduced rawMessageInfoFromMessageData function to reaction message spec
ClosedPublic
Actions

Authored by ginsu on Dec 2 2022, 3:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 12, 7:54 PM
Unknown Object (File)
Fri, Nov 8, 1:21 PM
Unknown Object (File)
Wed, Nov 6, 7:08 PM
Unknown Object (File)
Sat, Nov 2, 4:36 AM
Unknown Object (File)
Tue, Oct 29, 3:52 AM
Unknown Object (File)
Oct 28 2024, 1:00 AM
Unknown Object (File)
Oct 3 2024, 12:19 AM
Unknown Object (File)
Sep 28 2024, 5:21 AM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
atul
tomek
rohan
Commits
rCOMM45beae3d9b2f: [lib] introduced rawMessageInfoFromMessageData function to reaction message spec
Summary

introduced rawMessageInfoFromMessageData function to reaction message spec. rawMessageInfoFromMessageData converts the ReactionMessageData into a RawReactionMessageInfo

Depends on D5690
Linear Task: ENG-2245

Test Plan

Ran web and mobile app locally and nothing crashes/will be doing more tests on this message spec in subsequent diffs

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Dec 2 2022, 3:04 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptDec 2 2022, 3:04 PM
ginsu edited the summary of this revision. (Show Details)Dec 2 2022, 3:05 PM
ginsu added reviewers: atul, tomek, rohan.
ginsu added a parent revision: D5690: [lib] introduced reaction message spec boilerplate.
Harbormaster completed remote builds in B13955: Diff 19121.Dec 2 2022, 3:15 PM
ginsu requested review of this revision.Dec 2 2022, 3:15 PM
tomek accepted this revision.Dec 6 2022, 6:06 AM
rohan accepted this revision.Dec 7 2022, 10:01 AM
atul accepted this revision.Dec 7 2022, 11:47 AM
This revision is now accepted and ready to land.Dec 7 2022, 11:47 AM
ginsu updated this revision to Diff 19411.Dec 15 2022, 12:07 PM

rebase before landing

Harbormaster completed remote builds in B14188: Diff 19411.Dec 15 2022, 12:20 PM
Closed by commit rCOMM45beae3d9b2f: [lib] introduced rawMessageInfoFromMessageData function to reaction message spec (authored by ginsu). · Explain WhyDec 15 2022, 12:24 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM45beae3d9b2f: [lib] introduced rawMessageInfoFromMessageData function to reaction message spec.

Revision Contents
Changeset List

PathSize
lib/
shared/
messages/
8 lines

Diff 19411

View Options

lib/shared/messages/reaction-message-spec.js

Loading...