[services][backup] Use Rust service in Dockerfile
ClosedPublic
Actions

Authored by bartek on Jan 13 2023, 12:06 PM.

Details

Reviewers

• jon
varun
tomek

Commits

rCOMM01455650120f: [services][backup] Use Rust service in Dockerfile

Summary

Resolves ENG-2701

Mostly copy-pasted Dockerfile from Blob service
Made it more flexible by moving LOCALSTACK_URL and BLOB_SERVICE_URL to docker-compose.yml config
I left COMM_SERVICES_SANDBOX handled internally in-app, because it is more flexible - distinguishes truthy and falsy values - see this line

Depends on D6246

Test Plan

cd services
yarn init-local-cloud

# now this also starts blob service automatically
# no need to run 'yarn run-blob-service'
yarn run-backup-service-in-sandbox

# in a separate terminal
yarn run-integration-tests backup

Diff Detail

Repository

rCOMM Comm

Branch

barthap/backup-svc-docker

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Jan 13 2023, 12:06 PM

bartek held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptJan 13 2023, 12:06 PM

Harbormaster failed remote builds in B15362: Diff 20952!Jan 13 2023, 12:11 PM

bartek added inline comments.Jan 13 2023, 12:13 PM

services/backup/Dockerfile
49–52	I know that a preferred way is to use the `CMD ["command", "arg1" ...]` syntax, but it doesn't parse variables I passed in the `COMM_SERVICES_SANDBOX` env var instead of the `--sandbox` flag, because the in-app parser will automatically recognize truthy/falsy values (`"true"`/`"false"`, `"1"`/`"0"` etc) better than scripting here