Page MenuHomePhabricator
Differential D6211

[services][backup] SendLog 1/4 - create handler module
ClosedPublic
Actions

Authored by bartek on Jan 10 2023, 8:33 AM.
Tags
None
Referenced Files
F3502548: D6211.id21106.diff
Fri, Dec 20, 4:24 AM
F3502547: D6211.id21090.diff
Fri, Dec 20, 4:24 AM
F3502546: D6211.id20888.diff
Fri, Dec 20, 4:24 AM
F3502544: D6211.id20752.diff
Fri, Dec 20, 4:24 AM
F3502513: D6211.id.diff
Fri, Dec 20, 4:24 AM
F3502483: D6211.diff
Fri, Dec 20, 4:17 AM
Unknown Object (File)
Wed, Dec 18, 10:54 PM
Unknown Object (File)
Wed, Dec 18, 8:16 PM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
varun
tomek
• jon
• max
michal
Commits
rCOMM4d3018f17336: [services][backup] SendLog 1/4 - create handler module
Summary

Created module for SendLog endpoint and added its its invocation in the grpc handler.

Depends on D6207

Test Plan

Service builds and starts. This code has no logic yet.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Jan 10 2023, 8:33 AM
bartek held this revision as a draft.
Herald added subscribers: atul, ashoat. · View Herald TranscriptJan 10 2023, 8:33 AM
bartek added a child revision: D6212: [services][backup] SendLog 2/4 - handle non-data inputs.Jan 10 2023, 8:37 AM
Harbormaster completed remote builds in B15222: Diff 20752.Jan 10 2023, 8:48 AM
bartek added a reviewer: michal.Jan 11 2023, 10:39 AM
bartek published this revision for review.Jan 11 2023, 1:30 PM
tomek accepted this revision.Jan 12 2023, 7:05 AM
tomek added inline comments.
services/backup/src/service/mod.rs
122–123 ↗(On Diff #20752)

Do we have to clone database client?

This revision is now accepted and ready to land.Jan 12 2023, 7:05 AM
bartek added inline comments.Jan 12 2023, 7:12 AM
services/backup/src/service/mod.rs
122–123 ↗(On Diff #20752)

Good catch, a leftover from my previous implementation, where this code was unnecessarily run in a separate task

bartek updated this revision to Diff 20888.Jan 12 2023, 10:08 AM
  • Removed user_id field from logs
  • Removed unnecessary clone
Harbormaster completed remote builds in B15313: Diff 20888.Jan 12 2023, 10:24 AM
bartek updated this revision to Diff 21090.Jan 19 2023, 9:40 AM

Rebase

Harbormaster completed remote builds in B15468: Diff 21090.Jan 19 2023, 9:55 AM
Closed by commit rCOMM4d3018f17336: [services][backup] SendLog 1/4 - create handler module (authored by bartek). · Explain WhyJan 19 2023, 10:08 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM4d3018f17336: [services][backup] SendLog 1/4 - create handler module.

Revision Contents
Changeset List

PathSize
services/
backup/
src/
service/
handlers/
80 lines
46 lines

Diff 21090

View Options

services/backup/src/service/handlers/send_log.rs

Loading...
View Options

services/backup/src/service/mod.rs

Loading...