Page MenuHomePhabricator
Differential D6386

[backup-service] Use shared 'BlobClient' in workers
ClosedPublic
Actions

Authored by bartek on Jan 25 2023, 2:28 AM.
Tags
None
Referenced Files
F3374868: D6386.diff
Tue, Nov 26, 5:19 PM
Unknown Object (File)
Sun, Nov 10, 2:00 PM
Unknown Object (File)
Fri, Nov 8, 5:02 AM
Unknown Object (File)
Fri, Nov 8, 4:52 AM
Unknown Object (File)
Fri, Nov 8, 3:06 AM
Unknown Object (File)
Fri, Nov 8, 3:06 AM
Unknown Object (File)
Fri, Nov 8, 3:06 AM
Unknown Object (File)
Fri, Nov 8, 3:05 AM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
varun
• jon
michal
tomek
Commits
rCOMM20bce1cabf3a: [backup-service] Use shared 'BlobClient' in workers
Summary

Part of https://linear.app/comm/issue/ENG-2688/backup-service-reuse-single-blob-client-instance

Modified BlobDownloader::start and BlobUploader::start to take BlobClient as an argument instead of creating its own instance.

Depends on D6385

Test Plan

Ran backup service integration and performance tests to confirm it works as expected

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
services/
backup/
src/
blob/
13 lines
13 lines
service/
handlers/
8 lines
4 lines
2 lines
8 lines

Diff 21300

View Options

services/backup/src/blob/downloader.rs

Loading...
View Options

services/backup/src/blob/uploader.rs

Loading...
View Options

services/backup/src/service/handlers/add_attachments.rs

Loading...
View Options

services/backup/src/service/handlers/create_backup.rs

Loading...
View Options

services/backup/src/service/handlers/pull_backup.rs

Loading...
View Options

services/backup/src/service/handlers/send_log.rs

Loading...