Page MenuHomePhabricator
Differential D6299

[3/n] Native Typeahead - Change max height of textarea
ClosedPublic
Actions

Authored by • przemek on Jan 18 2023, 8:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 24, 4:01 PM
Unknown Object (File)
Thu, Apr 24, 1:00 AM
Unknown Object (File)
Thu, Apr 24, 12:50 AM
Unknown Object (File)
Wed, Apr 2, 5:24 PM
Unknown Object (File)
Thu, Mar 27, 1:16 AM
Unknown Object (File)
Mar 7 2025, 7:32 PM
Unknown Object (File)
Mar 7 2025, 7:32 PM
Unknown Object (File)
Mar 7 2025, 7:32 PM
View All Files
Subscribers
ashoat
atul
ginsu
inka
kamil
michal
tomek

Details

Reviewers
inka
ginsu
kamil
michal
tomek
Commits
rCOMM993313395be6: [3/n] Native Typeahead - Change max height of textarea
Summary

As mentioned here: https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC?node-id=4097:55267#330566637
We want to reduce height of text input.
That's what I did

Test Plan

Images on:

  • Android:

{F334601}

  • iOS

{F334602}

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• przemek created this revision.Jan 18 2023, 8:54 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 18 2023, 8:54 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jan 18 2023, 8:57 AM
Harbormaster failed remote builds in B15438: Diff 21047!
• przemek edited the test plan for this revision. (Show Details)Jan 19 2023, 6:36 AM
Harbormaster completed remote builds in B15438: Diff 21047.Jan 20 2023, 5:29 AM
• przemek requested review of this revision.Jan 20 2023, 5:29 AM
inka accepted this revision.Jan 24 2023, 2:55 AM
This revision is now accepted and ready to land.Jan 24 2023, 2:55 AM
• przemek added a parent revision: D6298: [2/n] Native Typeahead - Adding utility file and native regex.Jan 24 2023, 1:07 PM
• przemek added a child revision: D6300: [4/n] Native Typeahead - Add user search and thread members to props.
tomek accepted this revision.Jan 30 2023, 1:59 AM

The images from test plan don't show for me. The solution is described here: https://www.notion.so/commapp/Attaching-files-and-images-on-Phabricator-af8e2195fc91462689cc8de5c96a6759

ashoat updated this revision to Diff 22207.Feb 7 2023, 9:09 AM

Rebase

Harbormaster completed remote builds in B16236: Diff 22207.Feb 7 2023, 9:27 AM
Closed by commit rCOMM993313395be6: [3/n] Native Typeahead - Change max height of textarea (authored by • przemek, committed by ashoat). · Explain WhyFeb 7 2023, 2:37 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM993313395be6: [3/n] Native Typeahead - Change max height of textarea.

Revision Contents
Changeset List

PathSize
native/
chat/
2 lines

Diff 22207

View Options

native/chat/chat-input-bar.react.js

  • This file was added.
// @flow
import { createDrawerNavigator } from '@react-navigation/drawer';
import * as React from 'react';
import { Dimensions, View } from 'react-native';
import { useStyles } from '../themes/colors';
import type { AppNavigationProp } from './app-navigator.react';
import CommunityDrawerContent from './community-drawer-content.react';
import { TabNavigatorRouteName } from './route-names';
import type { NavigationRoute } from './route-names';
import TabNavigator from './tab-navigator.react';
const Drawer = createDrawerNavigator();
const communityDrawerContent = () => <CommunityDrawerContent />;
type Props = {
+navigation: AppNavigationProp<'CommunityDrawerNavigator'>,
+route: NavigationRoute<'CommunityDrawerNavigator'>,
};
// eslint-disable-next-line no-unused-vars
function CommunityDrawerNavigator(props: Props): React.Node {
const styles = useStyles(unboundStyles);
const screenOptions = React.useMemo(
() => ({
drawerStyle: styles.drawerStyle,
}),
[styles.drawerStyle],
);
return (
<View style={styles.drawerView}>
<Drawer.Navigator
screenOptions={screenOptions}
drawerContent={communityDrawerContent}
tomekUnsubmitted
Not Done
Inline Actions
screenOptions={screenOptions}
- drawerContent={communityDrawerContent}
+ drawerContent={CommunityDrawerContent}
>
<Drawer.Screen name={TabNavigatorRouteName} component={TabNavigator} />

Are we sure that Flow doesn't allow us to use CommunityDrawerContent directly? Ultimately, it is a function that doesn't take arguments, so it should be possible to use here (but maybe Flow disagrees with that).

tomek: Are we sure that Flow doesn't allow us to use `CommunityDrawerContent` directly? Ultimately, it…
inkaAuthorUnsubmitted
Done
Inline Actions

Flow doesn't allow that. It says that React.ComponentType is incompatible with function type.
React.ComponentType comes from the memoization of CommunityDrawerContent

inka: Flow doesn't allow that. It says that `React.ComponentType is incompatible with function type`.
>
<Drawer.Screen name={TabNavigatorRouteName} component={TabNavigator} />
</Drawer.Navigator>
</View>
);
}
const unboundStyles = {
drawerView: {
flex: 1,
},
drawerStyle: {
width: Dimensions.get('window').width - 36,
ashoatUnsubmitted
Not Done
Inline Actions

Following ENG-2413 getting cancelled, we should remove this. Mentioning here because there is no longer a Linear task tracking the removal

ashoat: Following [ENG-2413](https://linear.app/comm/issue/ENG-2413/use-a-hook-in-drawer-navigator-for…
},
};
export { CommunityDrawerNavigator };