We have to introduce a function that parses strings into numbers, because map keys in Dynamo are plain strings instead of AttributeValues. This affects what we store in DBItemError - now it is either AttributeValue or a String.
Depends on D6854
Details
Details
Tested with the rest of the stack.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| services/feature-flags/src/database.rs | ||
|---|---|---|
| 40–44 ↗ | (On Diff #23005) | This is copied from other services. I had to remove it from the previous diff as this case couldn't be matched. |
| services/feature-flags/src/database.rs | ||
|---|---|---|
| 101–109 ↗ | (On Diff #23005) | Don't you want to distinguish between IncorrectType and Missing, the same way as in parse_{string,bool}_attribute? If this is done deliberately, just let me know |
| 116–123 ↗ | (On Diff #23005) | Wouldn't it work this way? Or are error types incompatible? |