[native] Disable typeahead and media buttons in edit mode
ClosedPublic
Actions

Authored by • kuba on Apr 14 2023, 1:34 AM.

Details

Reviewers

michal
inka

Commits

rCOMM8be441fb132d: [native] Disable typeahead and media buttons in edit mode

Summary

We don't want to display typeahead and media buttons in edit mode.

Test Plan

Run the app. Entered exit mode. Checked if the media buttons disappeared, and if typeahead tooltip wasn't showing. Exited edit mode. Checked if everything appeared again.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• kuba created this revision.Apr 14 2023, 1:34 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 14 2023, 1:34 AM

• kuba added a parent revision: D7447: [native] Highlighting edited message.Apr 14 2023, 1:34 AM

Harbormaster completed remote builds in B18365: Diff 25159.Apr 14 2023, 1:52 AM

• kuba requested review of this revision.Apr 14 2023, 1:52 AM

• kuba added a child revision: D7484: [native] Scrolling to the edited message.Apr 18 2023, 3:26 AM

inka added inline comments.Apr 18 2023, 7:03 AM

native/chat/chat-input-bar.react.js
634–636	can you instead make the `expandoButton` null if `this.isEditMode()` or `!this.state.buttonsExpanded` ? Like we do with `statusBar` in most places. This will also get rid of `{this.state.buttonsExpanded ? expandoButton : null}` from JSX.

• kuba added inline comments.Apr 19 2023, 2:46 AM

native/chat/chat-input-bar.react.js
634–636	If I use `display: 'none'`, the margin from the left side is automatically set. In that case we have exactly the same margin from the left as there would be the arrow. As we discussed yesterday in the office, I asked Ted about the paddings on Figma.