Paths

Table of Contentst

Differential D8058

[native] Pass whether created community is `ANNOUNCEMENT` to `CommunityCreationMembers`
ClosedPublic
Actions

Authored by atul on Jun 1 2023, 1:31 PM.

Tags

None

Referenced Files

	F3493277: D8058.id27371.diff
	Thu, Dec 19, 2:45 AM

	F3492410: D8058.diff
	Wed, Dec 18, 11:45 PM

	Unknown Object (File)
	Sun, Dec 1, 6:04 AM

	Unknown Object (File)
	Nov 8 2024, 4:00 AM

	Unknown Object (File)
	Nov 6 2024, 9:32 PM

	Unknown Object (File)
	Nov 6 2024, 6:07 PM

	Unknown Object (File)
	Nov 6 2024, 2:23 PM

	Unknown Object (File)
	Oct 28 2024, 1:56 PM

View All 60 Files

Subscribers

Details

Reviewers

ashoat
ginsu

Commits

rCOMM414dbe4650a0: [native] Pass whether created community is `ANNOUNCEMENT` to…

Summary

We pass announcement: boolean to CommunityCreationMembers so we can conditionally pass COMMUNITY_ANNOUNCEMENT_ROOT or COMMUNITY_ROOT to getPotentialMemberItems(...)

Depends on D8057

Test Plan

Created communities with announcement toggled on/off in CommunityConfig and then logged value in CommunityCreationMembers to ensure it matched up.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Jun 1 2023, 1:31 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 1 2023, 1:31 PM

atul published this revision for review.Jun 1 2023, 1:44 PM

Harbormaster completed remote builds in B19963: Diff 27371.Jun 1 2023, 1:51 PM

ashoat accepted this revision.Jun 1 2023, 2:00 PM

This revision is now accepted and ready to land.Jun 1 2023, 2:00 PM

Closed by commit rCOMM414dbe4650a0: [native] Pass whether created community is `ANNOUNCEMENT` to… (authored by atul). · Explain WhyJun 2 2023, 10:42 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM414dbe4650a0: [native] Pass whether created community is `ANNOUNCEMENT` to….

Revision Contents
Changeset List

Path

Size

native/

community-creation/

community-configuration.react.js

12 lines

community-creation-members.react.js

19 lines

navigation/

3 lines

Diff 27408

native/community-creation/community-configuration.react.js

Loading...

native/community-creation/community-creation-members.react.js

Loading...

native/navigation/route-names.js

Loading...