Page MenuHomePhabricator
Differential D8241

[web] Add footers to message search modal
ClosedPublic
Actions

Authored by inka on Jun 16 2023, 7:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 15, 5:46 PM
Unknown Object (File)
Thu, Mar 13, 7:12 AM
Unknown Object (File)
Tue, Mar 4, 10:29 AM
Unknown Object (File)
Tue, Mar 4, 10:29 AM
Unknown Object (File)
Tue, Mar 4, 10:29 AM
Unknown Object (File)
Tue, Mar 4, 10:29 AM
Unknown Object (File)
Tue, Mar 4, 10:29 AM
Unknown Object (File)
Tue, Mar 4, 10:29 AM
View All Files
Subscribers
ashoat
• ted
tomek

Details

Reviewers
kamil
michal
• kuba
Commits
rCOMMa05faa28187f: [web] Add footers to message search modal
Summary

issue: https://linear.app/comm/issue/ENG-4102/add-footers-to-message-search-modal
See the designs in the linked issue

The loader appears whenever no other footer is visible

Test Plan

checked that the right footers appear in the right circumstances

Diff Detail

Repository
rCOMM Comm
Branch
inka/search_web
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Jun 16 2023, 7:15 AM
Herald added subscribers: • ted, tomek, ashoat. · View Herald TranscriptJun 16 2023, 7:15 AM
inka added a parent revision: D8240: [web] Add message search modal.Jun 16 2023, 7:17 AM
inka edited the summary of this revision. (Show Details)
inka attached a referenced file: F591284: Screen Recording 2023-06-16 at 16.17.49.mov. (Show Details)
Harbormaster completed remote builds in B20314: Diff 27839.Jun 16 2023, 7:57 AM
inka requested review of this revision.Jun 16 2023, 7:57 AM
ashoat added inline comments.Jun 17 2023, 6:50 AM
web/modals/search/message-search-modal.react.js
165 ↗(On Diff #27839)

Wondering why we can't just do this. I might be missing something, maybe that leads to extra spaces?

michal accepted this revision.Jun 19 2023, 9:16 AM
This revision is now accepted and ready to land.Jun 19 2023, 9:16 AM
inka updated this revision to Diff 27878.Jun 20 2023, 1:28 AM

Rebase, address review

Harbormaster completed remote builds in B20337: Diff 27878.Jun 20 2023, 1:46 AM
ashoat added inline comments.Jun 20 2023, 5:52 AM
web/modals/search/message-search-modal.react.js
179 ↗(On Diff #27878)

This is a comma splice. We should avoid joining sentences with commas

inka updated this revision to Diff 27887.Jun 20 2023, 6:09 AM

Address review

inka mentioned this in D8258: [native] Remove comma splice in message search.Jun 20 2023, 6:13 AM
inka added inline comments.Jun 20 2023, 6:13 AM
web/modals/search/message-search-modal.react.js
179 ↗(On Diff #27878)

I added D8258 to change this on native as well

Harbormaster completed remote builds in B20346: Diff 27887.Jun 20 2023, 6:26 AM
• InkaSokolowska mentioned this in rCOMM2bc2997dc0a2: [native] Remove comma splice in message search.Jun 20 2023, 6:48 AM
inka added a child revision: D8272: [web] Add message search context.Jun 21 2023, 5:38 AM
inka updated this revision to Diff 27994.Jun 22 2023, 7:11 AM

Rebase

Harbormaster failed remote builds in B20420: Diff 27994!Jun 22 2023, 7:24 AM
inka updated this revision to Diff 28002.Jun 22 2023, 7:51 AM

Rebase

Harbormaster failed remote builds in B20428: Diff 28002!Jun 22 2023, 8:14 AM
Harbormaster completed remote builds in B20428: Diff 28002.Jun 26 2023, 7:37 AM
Closed by commit rCOMMa05faa28187f: [web] Add footers to message search modal (authored by • InkaSokolowska). · Explain WhyJun 27 2023, 4:25 AM
This revision was automatically updated to reflect the committed changes.
• InkaSokolowska added a commit: rCOMMa05faa28187f: [web] Add footers to message search modal.

Revision Contents
Changeset List

PathSize
web/
modals/
search/
8 lines
26 lines
1 line

Diff 27887

View Options

web/modals/search/message-search-modal.css

Show First 20 Lines • Show All 69 Lines • ▼ Show 20 Lines switch (this->state) {
case State::DATA_CHUNKS: { case State::DATA_CHUNKS: {
// TODO initialize blob client reactor // TODO initialize blob client reactor
if (ServiceBlobClient::getInstance().putReactor == nullptr) { if (ServiceBlobClient::getInstance().putReactor == nullptr) {
throw std::runtime_error( throw std::runtime_error(
"blob client reactor has not been initialized"); "blob client reactor has not been initialized");
} }
ServiceBlobClient::getInstance().putReactor->scheduleSendingDataChunk( ServiceBlobClient::getInstance().putReactor->scheduleSendingDataChunk(
request.newcompactionchunk()); std::make_unique<std::string>(
std::move(*request.mutable_newcompactionchunk())));
return nullptr; return nullptr;
} }
} }
throw std::runtime_error("new backup - invalid state"); throw std::runtime_error("new backup - invalid state");
} }
void CreateNewBackupReactor::doneCallback() { void CreateNewBackupReactor::doneCallback() {
ServiceBlobClient::getInstance().putReactor->scheduleSendingDataChunk(""); ServiceBlobClient::getInstance().putReactor->scheduleSendingDataChunk(
std::make_unique<std::string>(""));
} }
} // namespace reactor } // namespace reactor
} // namespace network } // namespace network
} // namespace comm } // namespace comm
View Options

web/modals/search/message-search-modal.react.js

Show First 20 Lines • Show All 69 Lines • ▼ Show 20 Lines switch (this->state) {
case State::DATA_CHUNKS: { case State::DATA_CHUNKS: {
// TODO initialize blob client reactor // TODO initialize blob client reactor
if (ServiceBlobClient::getInstance().putReactor == nullptr) { if (ServiceBlobClient::getInstance().putReactor == nullptr) {
throw std::runtime_error( throw std::runtime_error(
"blob client reactor has not been initialized"); "blob client reactor has not been initialized");
} }
ServiceBlobClient::getInstance().putReactor->scheduleSendingDataChunk( ServiceBlobClient::getInstance().putReactor->scheduleSendingDataChunk(
request.newcompactionchunk()); std::make_unique<std::string>(
std::move(*request.mutable_newcompactionchunk())));
return nullptr; return nullptr;
} }
} }
throw std::runtime_error("new backup - invalid state"); throw std::runtime_error("new backup - invalid state");
} }
void CreateNewBackupReactor::doneCallback() { void CreateNewBackupReactor::doneCallback() {
ServiceBlobClient::getInstance().putReactor->scheduleSendingDataChunk(""); ServiceBlobClient::getInstance().putReactor->scheduleSendingDataChunk(
std::make_unique<std::string>(""));
} }
} // namespace reactor } // namespace reactor
} // namespace network } // namespace network
} // namespace comm } // namespace comm
View Options

web/theme.css

Show First 20 Lines • Show All 69 Lines • ▼ Show 20 Lines switch (this->state) {
case State::DATA_CHUNKS: { case State::DATA_CHUNKS: {
// TODO initialize blob client reactor // TODO initialize blob client reactor
if (ServiceBlobClient::getInstance().putReactor == nullptr) { if (ServiceBlobClient::getInstance().putReactor == nullptr) {
throw std::runtime_error( throw std::runtime_error(
"blob client reactor has not been initialized"); "blob client reactor has not been initialized");
} }
ServiceBlobClient::getInstance().putReactor->scheduleSendingDataChunk( ServiceBlobClient::getInstance().putReactor->scheduleSendingDataChunk(
request.newcompactionchunk()); std::make_unique<std::string>(
std::move(*request.mutable_newcompactionchunk())));
return nullptr; return nullptr;
} }
} }
throw std::runtime_error("new backup - invalid state"); throw std::runtime_error("new backup - invalid state");
} }
void CreateNewBackupReactor::doneCallback() { void CreateNewBackupReactor::doneCallback() {
ServiceBlobClient::getInstance().putReactor->scheduleSendingDataChunk(""); ServiceBlobClient::getInstance().putReactor->scheduleSendingDataChunk(
std::make_unique<std::string>(""));
} }
} // namespace reactor } // namespace reactor
} // namespace network } // namespace network
} // namespace comm } // namespace comm