[web] Indicate success via `saveAvatarButton` on success
ClosedPublic
Actions

Authored by atul on Jun 21 2023, 9:42 PM.

Details

Reviewers

ashoat
ginsu
rohan

Commits

rCOMMb904988eee39: [web] Indicate success via `saveAvatarButton` on success

Summary

Style button and show success message when updating emoji avatar succeeds.

Depends on D8280

Test Plan

Works as expected:

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Jun 21 2023, 9:42 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 21 2023, 9:42 PM

atul edited the test plan for this revision. (Show Details)Jun 21 2023, 9:43 PM

atul added a child revision: D8283: [web] Consolidate `errorMessage` and `updateSuccessful` state in `EmojiAvatarSelectionModal`.Jun 21 2023, 9:58 PM

Harbormaster completed remote builds in B20408: Diff 27980.Jun 21 2023, 10:01 PM

atul requested review of this revision.Jun 21 2023, 10:01 PM

rohan accepted this revision.Jun 22 2023, 1:21 PM

This revision is now accepted and ready to land.Jun 22 2023, 1:21 PM

rebase before landing

This revision was landed with ongoing or failed builds.Jun 23 2023, 9:07 PM

Closed by commit rCOMMb904988eee39: [web] Indicate success via `saveAvatarButton` on success. · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMb904988eee39: [web] Indicate success via `saveAvatarButton` on success.

Harbormaster completed remote builds in B20493: Diff 28079.Jun 23 2023, 9:29 PM

Revision Contents
Changeset List

Path

Size

web/

avatars/

emoji-avatar-selection-modal.react.js

21 lines

Diff 28093

View Options

web/avatars/emoji-avatar-selection-modal.react.js

[web] Indicate success via `saveAvatarButton` on successClosedPublicActions