Page MenuHomePhabricator
Differential D8979

[keyserver] Determine which infos have invalid hashes based on specs
ClosedPublic
Actions

Authored by tomek on Aug 28 2023, 6:28 AM.
Tags
None
Referenced Files
F2827982: D8979.id30581.diff
Fri, Sep 27, 1:16 PM
F2827979: D8979.id30437.diff
Fri, Sep 27, 1:16 PM
F2827913: D8979.id.diff
Fri, Sep 27, 1:15 PM
F2827676: D8979.diff
Fri, Sep 27, 1:01 PM
Unknown Object (File)
Fri, Sep 20, 5:37 AM
Unknown Object (File)
Sun, Sep 15, 8:13 PM
Unknown Object (File)
Aug 29 2024, 3:11 AM
Unknown Object (File)
Aug 25 2024, 5:32 PM
View All 80 Files
Subscribers
ashoat

Details

Reviewers
kamil
bartek
inka
Commits
rCOMM9f679f8667b0: [keyserver] Determine which infos have invalid hashes based on specs
Summary

Check if a key is top level - it means that there are infos in the collection which aren't synchronized. Iterate over them and compute hashes for each item.
When a spec doesn't specify innerHashKey, return the values immediately - currently we do that only for currentUserInfo because there's exactly one current user.

https://linear.app/comm/issue/ENG-4631/migrate-checkstate-from-session-utils-to-a-spec

Depends on D8977

Test Plan

Modify keyserver db and check if the store get fixed.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Aug 28 2023, 6:28 AM
Herald added a subscriber: ashoat. · View Herald TranscriptAug 28 2023, 6:29 AM
Harbormaster completed remote builds in B22171: Diff 30437.Aug 28 2023, 6:46 AM
tomek requested review of this revision.Aug 28 2023, 6:46 AM
bartek accepted this revision.Aug 29 2023, 2:21 AM

So it means that innerHashKey is defined only for collections, and should be null / undefined for top-level, non-iterable infos

This revision is now accepted and ready to land.Aug 29 2023, 2:21 AM
tomek added a child revision: D9008: [keyserver] Determine which infos to send based on specs.Aug 29 2023, 6:16 AM
tomek added a comment.Aug 30 2023, 7:23 AM
In D8979#265014, @bartek wrote:

So it means that innerHashKey is defined only for collections, and should be null / undefined for top-level, non-iterable infos

Yes, exactly.

Closed by commit rCOMM9f679f8667b0: [keyserver] Determine which infos have invalid hashes based on specs (authored by tomek). · Explain WhyAug 30 2023, 9:16 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM9f679f8667b0: [keyserver] Determine which infos have invalid hashes based on specs.

Revision Contents
Changeset List

PathSize
keyserver/
src/
socket/
43 lines

Diff 30581

View Options

keyserver/src/socket/session-utils.js

Loading...