Page MenuHomePhabricator

[lib] Refactor the remaining part of the hash logic using specs
ClosedPublic

Authored by tomek on Aug 31 2023, 8:35 AM.
Tags
None
Referenced Files
F2912069: D9049.id30658.diff
Mon, Oct 7, 1:21 AM
F2911057: D9049.diff
Sun, Oct 6, 11:23 PM
Unknown Object (File)
Fri, Sep 27, 1:16 PM
Unknown Object (File)
Fri, Sep 27, 1:16 PM
Unknown Object (File)
Fri, Sep 27, 1:15 PM
Unknown Object (File)
Fri, Sep 27, 1:01 PM
Unknown Object (File)
Sat, Sep 14, 2:51 PM
Unknown Object (File)
Aug 29 2024, 3:19 AM
Subscribers

Details

Summary

We can iterate over specs and use the same logic which was used for each infos collection.

https://linear.app/comm/issue/ENG-4813/migrate-getclientresponsesselector-to-a-spec

Depends on D9048

Test Plan

Modify server state and check if state check fixes client state. Bring back the old implementation and check if the hashResults are the same.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable