Differential D9257
[lib] Move entries updates logic into a spec Authored by tomek on Sep 21 2023, 8:22 AM. Tags None Referenced Files
Details Move the logic into specs. Entry store update is based on mutating the input, so it isn't ideal, but I didn't want to alter the logic significantly as a part of this simple refactoring. Depends on D9245 https://linear.app/comm/issue/ENG-4241/handle-processupdatesactiontype-as-a-part-of-a-spec Check if joining a thread and updating an entry correctly affect the store.
Diff Detail
Event TimelineComment Actions Not a fan of keeping the solution with mutating input, but accepting this since fixing this is not a part of this work. Maybe we can at least create a task to improve this? Comment Actions Makes sense. Created a task for it https://linear.app/comm/issue/ENG-5158/consider-using-an-immutable-approach-in-entries-updates-spec |