Page MenuHomePhabricator
Differential D9271

[native] improve organization of user profiles work
ClosedPublic
Actions

Authored by ginsu on Sep 22 2023, 2:03 PM.
Tags
None
Referenced Files
F3343808: D9271.id31563.diff
Fri, Nov 22, 4:09 AM
F3343788: D9271.id31555.diff
Fri, Nov 22, 4:04 AM
F3343607: D9271.id31380.diff
Fri, Nov 22, 3:33 AM
F3340499: D9271.diff
Thu, Nov 21, 9:53 PM
Unknown Object (File)
Tue, Nov 19, 4:56 PM
Unknown Object (File)
Tue, Nov 5, 1:28 PM
Unknown Object (File)
Fri, Nov 1, 12:42 PM
Unknown Object (File)
Fri, Nov 1, 12:23 PM
View All 97 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMM588581374141: [native] improve organization of user profiles work
Summary

Working on user profiles, I was introducing/will be continueing to introduce more files for user profiles. To better organize this, I think we should have a dedicated folder called user-profile to house all of the user profile files/code so we can keep everything in once place.

I also renamed the bottom-sheets directory => bottom-sheet

Depends on D9260

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Sep 22 2023, 2:03 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 22 2023, 2:03 PM
ginsu edited the summary of this revision. (Show Details)Sep 22 2023, 2:03 PM
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D9260: [native] improve BottomSheet component close function.
ginsu edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B22810: Diff 31380.Sep 22 2023, 2:22 PM
ginsu requested review of this revision.Sep 22 2023, 2:22 PM
ginsu added a child revision: D9272: [native] introduce BottomSheetProvider.Sep 24 2023, 11:57 PM
atul accepted this revision.Sep 26 2023, 1:28 PM

Just skimmed through, trusting CI here

This revision is now accepted and ready to land.Sep 26 2023, 1:28 PM
ginsu updated this revision to Diff 31555.Sep 29 2023, 11:48 AM

rebase before landing

Harbormaster completed remote builds in B22921: Diff 31555.Sep 29 2023, 12:06 PM
Closed by commit rCOMM588581374141: [native] improve organization of user profiles work (authored by ginsu). · Explain WhySep 29 2023, 12:10 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM588581374141: [native] improve organization of user profiles work.

Revision Contents
Changeset List

Diff 31380

View Options

native/bottom-sheet/bottom-sheet-backdrop.react.js

Loading...
View Options

native/bottom-sheet/bottom-sheet-handle.react.js

Loading...
View Options

native/bottom-sheet/bottom-sheet.react.js

Loading...
View Options

native/bottom-sheets/bottom-sheet-backdrop.react.js

Loading...
View Options

native/bottom-sheets/bottom-sheet-handle.react.js

Loading...
View Options

native/bottom-sheets/bottom-sheet.react.js

Loading...
View Options

native/bottom-sheets/user-profile-bottom-sheet.react.js

Loading...
View Options

native/components/user-profile-message-button.react.js

Loading...
View Options

native/components/user-profile-relationship-button.react.js

Loading...
View Options

native/components/user-profile.react.js

Loading...
View Options

native/navigation/root-navigator.react.js

Loading...
View Options

native/navigation/route-names.js

Loading...
View Options

native/user-profile/user-profile-bottom-sheet.react.js

Loading...
View Options

native/user-profile/user-profile-message-button.react.js

Loading...
View Options

native/user-profile/user-profile-relationship-button.react.js

Loading...
View Options

native/user-profile/user-profile.react.js

Loading...