Page MenuHomePhabricator
Differential D9311

[Commtest] fix Clippy warnings and typos
ClosedPublic
Actions

Authored by kamil on Sep 28 2023, 7:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 1, 10:48 AM
Unknown Object (File)
Fri, Nov 1, 10:48 AM
Unknown Object (File)
Fri, Nov 1, 10:45 AM
Unknown Object (File)
Fri, Nov 1, 10:24 AM
Unknown Object (File)
Fri, Nov 1, 6:41 AM
Unknown Object (File)
Tue, Oct 29, 3:43 PM
Unknown Object (File)
Sat, Oct 26, 1:57 AM
Unknown Object (File)
Wed, Oct 23, 6:50 AM
View All 69 Files
Subscribers
ashoat
bartek
tomek

Details

Reviewers
michal
bartek
varun
• jon
Commits
rCOMMf5edadea6168: [Commtest] fix Clippy warnings and typos
Summary

As suggested by @bartek I started using clippy linter for rust, but it's hard when it generates a lot of warnings in old code - fixing all, and some typos.

Depends on D9310

Test Plan

Run tests

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Sep 28 2023, 7:29 AM
kamil held this revision as a draft.
Herald added a reviewer: • jon. · View Herald TranscriptSep 28 2023, 7:29 AM
Herald added subscribers: tomek, ashoat. · View Herald Transcript
kamil added a child revision: D9312: [Commtest] add mock olm accounts, configure creating authenticated device.Sep 28 2023, 7:30 AM
Harbormaster completed remote builds in B22890: Diff 31521.Sep 28 2023, 7:46 AM
kamil published this revision for review.Sep 28 2023, 8:08 AM
bartek accepted this revision.Sep 29 2023, 12:59 AM
bartek added inline comments.
services/commtest/tests/tunnelbroker_integration_tests.rs
53

finally 😁

This revision is now accepted and ready to land.Sep 29 2023, 12:59 AM
michal accepted this revision.Sep 29 2023, 2:00 AM
Closed by commit rCOMMf5edadea6168: [Commtest] fix Clippy warnings and typos (authored by kamil). · Explain WhyOct 11 2023, 7:39 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMf5edadea6168: [Commtest] fix Clippy warnings and typos.

Revision Contents
Changeset List

PathSize
services/
commtest/
2 lines
src/
identity/
8 lines
16 lines
tests/
4 lines
tunnelbroker_integration_tests.rs
tunnelbroker_integration_test.rs
7 lines
identity/
src/
4 lines
shared/
tunnelbroker_messages/
src/
messages/
2 lines
2 lines
6 lines

Diff 31521

View Options

services/commtest/build.rs

Loading...
View Options

services/commtest/src/identity/device.rs

Loading...
View Options

services/commtest/src/tools.rs

Loading...
View Options

services/commtest/tests/identity_tunnelbroker_tests.rs

Loading...
View Options

services/commtest/tests/tunnelbroker_integration_test.rs

Loading...
View Options

services/commtest/tests/tunnelbroker_integration_tests.rs

Loading...
View Options

services/identity/src/config.rs

Loading...
View Options

shared/tunnelbroker_messages/src/messages/keys.rs

Loading...
View Options

shared/tunnelbroker_messages/src/messages/mod.rs

Loading...
View Options

shared/tunnelbroker_messages/src/messages/session.rs

Loading...