Page MenuHomePhabricator
Differential D9368

[lib][web][native] Refactor actions in link-actions.js
ClosedPublic
Actions

Authored by inka on Oct 5 2023, 5:19 AM.
Tags
None
Referenced Files
F3535506: D9368.id32759.diff
Wed, Dec 25, 3:54 PM
F3535504: D9368.id32647.diff
Wed, Dec 25, 3:54 PM
F3535503: D9368.id32620.diff
Wed, Dec 25, 3:54 PM
F3535502: D9368.id31681.diff
Wed, Dec 25, 3:54 PM
F3535501: D9368.id31684.diff
Wed, Dec 25, 3:54 PM
F3535488: D9368.diff
Wed, Dec 25, 3:42 PM
F3531941: D9368.id32759.diff
Wed, Dec 25, 8:34 AM
Unknown Object (File)
Tue, Dec 24, 4:22 AM
View All Files
Subscribers
ashoat
tomek
will

Details

Reviewers
michal
kamil
ginsu
Commits
rCOMMbb6079c8aa9e: [lib][web][native] Refactor actions in link-actions.js
Summary

issue: https://linear.app/comm/issue/ENG-4681/create-action-objects-for-all-actions

verifyInviteLink cannot be refactored yet. It will be done in https://linear.app/comm/issue/ENG-5164/refactor-verifyinvitelink-action

Test Plan

Tested that the actions work as expected

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Oct 5 2023, 5:19 AM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 5 2023, 5:19 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 5 2023, 5:25 AM
Harbormaster failed remote builds in B23001: Diff 31681!
inka added a parent revision: D9356: [lib][web][native] Refactor actions in entry-actions.js.Oct 5 2023, 6:19 AM
inka added a child revision: D9369: [lib][web][native] Refactor actions in message-report-actions.js.
inka updated this revision to Diff 31684.Oct 5 2023, 6:31 AM

Retry

Harbormaster completed remote builds in B23004: Diff 31684.Oct 5 2023, 6:48 AM
inka requested review of this revision.Oct 5 2023, 6:48 AM
michal accepted this revision.Oct 11 2023, 1:19 AM
michal added inline comments.
lib/actions/link-actions.js
95–97

We shouldn't hide await inside of an another expression

This revision is now accepted and ready to land.Oct 11 2023, 1:19 AM
inka updated this revision to Diff 32620.Nov 2 2023, 7:24 AM

Address review

Harbormaster completed remote builds in B23666: Diff 32620.Nov 2 2023, 7:42 AM
inka updated this revision to Diff 32647.Nov 2 2023, 12:47 PM

Rebase

Harbormaster completed remote builds in B23693: Diff 32647.Nov 2 2023, 1:38 PM
Closed by commit rCOMMbb6079c8aa9e: [lib][web][native] Refactor actions in link-actions.js (authored by inka). · Explain WhyNov 6 2023, 5:44 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMMbb6079c8aa9e: [lib][web][native] Refactor actions in link-actions.js.

Revision Contents
Changeset List

PathSize
lib/
actions/
85 lines
hooks/
13 lines
native/
navigation/
9 lines
web/
invite-links/
9 lines

Diff 31684

View Options

lib/actions/link-actions.js

Loading...
View Options

lib/hooks/invite-links.js

Loading...
View Options

native/navigation/community-drawer-content.react.js

Loading...
View Options

web/invite-links/invite-links-refresher.react.js

Loading...