[lib] Move entries updates logic into a spec
ClosedPublic
Actions

Authored by tomek on Sep 21 2023, 8:22 AM.

Details

Reviewers

kamil
bartek
inka

Commits

rCOMM0ebca826d916: [lib] Move entries updates logic into a spec

Summary

Move the logic into specs. Entry store update is based on mutating the input, so it isn't ideal, but I didn't want to alter the logic significantly as a part of this simple refactoring.

Depends on D9245

https://linear.app/comm/issue/ENG-4241/handle-processupdatesactiontype-as-a-part-of-a-spec

Test Plan

Check if joining a thread and updating an entry correctly affect the store.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Sep 21 2023, 8:22 AM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 21 2023, 8:22 AM

Harbormaster completed remote builds in B22781: Diff 31340.Sep 21 2023, 8:40 AM

tomek requested review of this revision.Sep 21 2023, 8:40 AM

tomek added a child revision: D9268: [lib] Move current user updates logic into a spec.Sep 22 2023, 6:36 AM

Not a fan of keeping the solution with mutating input, but accepting this since fixing this is not a part of this work. Maybe we can at least create a task to improve this?

kamil accepted this revision.Sep 25 2023, 2:31 AM

This revision is now accepted and ready to land.Sep 25 2023, 2:31 AM

In D9257#272801, @kamil wrote:

Not a fan of keeping the solution with mutating input, but accepting this since fixing this is not a part of this work. Maybe we can at least create a task to improve this?

Makes sense. Created a task for it https://linear.app/comm/issue/ENG-5158/consider-using-an-immutable-approach-in-entries-updates-spec

Closed by commit rCOMM0ebca826d916: [lib] Move entries updates logic into a spec (authored by tomek). · Explain WhyOct 9 2023, 3:57 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM0ebca826d916: [lib] Move entries updates logic into a spec.