Page MenuHomePhabricator
Differential D9656

[keyserver] Convert raw update infos in a spec
ClosedPublic
Actions

Authored by tomek on Oct 31 2023, 8:43 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 17, 11:32 AM
Unknown Object (File)
Thu, Apr 17, 11:24 AM
Unknown Object (File)
Thu, Apr 17, 6:40 AM
Unknown Object (File)
Wed, Apr 16, 8:27 PM
Unknown Object (File)
Tue, Apr 15, 10:04 PM
Unknown Object (File)
Mon, Apr 14, 6:06 PM
Unknown Object (File)
Thu, Apr 10, 7:50 AM
Unknown Object (File)
Mon, Apr 7, 7:48 PM
View All 82 Files
Subscribers
ashoat
will

Details

Reviewers
kamil
inka
bartek
Commits
rCOMMa1bec7ba5a40: [keyserver] Convert raw update infos in a spec
Summary

Move the logic to a spec.

Depends on D9655

Test Plan

Generate some updates, reintroduce old code, and compare new with old result using _.isEqual

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

Diff 32554

View Options

keyserver/src/creators/update-creator.js

Show All 35 Lines
const userMentionsExtractionRegex = new RegExp( const userMentionsExtractionRegex = new RegExp(
`\\B(@(${oldValidUsernameRegexString}))\\b`, `\\B(@(${oldValidUsernameRegexString}))\\b`,
'g', 'g',
); );
const chatMentionRegexString = `^(?<!\\\\)(@\\[\\[([0-9,|]+):(${validChatNameRegexString}?)(?<!\\\\)\\]\\])`; const chatMentionRegexString = `^(?<!\\\\)(@\\[\\[([0-9,|]+):(${validChatNameRegexString}?)(?<!\\\\)\\]\\])`;
const chatMentionRegex: RegExp = new RegExp(chatMentionRegexString); const chatMentionRegex: RegExp = new RegExp(chatMentionRegexString);
function encodeChatMentionText(text: string): string {
return text.replace(/]/g, '\\]');
}
function decodeChatMentionText(text: string): string { function decodeChatMentionText(text: string): string {
return text.replace(/\\]/g, ']'); return text.replace(/\\]/g, ']');
} }
function extractUserMentionsFromText(text: string): string[] { function extractUserMentionsFromText(text: string): string[] {
const iterator = text.matchAll(userMentionsExtractionRegex); const iterator = text.matchAll(userMentionsExtractionRegex);
return [...iterator].map(matches => matches[2]); return [...iterator].map(matches => matches[2]);
} }
▲ Show 20 Lines • Show All 69 Lines • ▼ Show 20 Linesexport {
markdownUserMentionRegex, markdownUserMentionRegex,
isUserMentioned, isUserMentioned,
extractUserMentionsFromText, extractUserMentionsFromText,
getMentionTypeaheadUserSuggestions, getMentionTypeaheadUserSuggestions,
getNewTextAndSelection, getNewTextAndSelection,
getTypeaheadRegexMatches, getTypeaheadRegexMatches,
getUserMentionsCandidates, getUserMentionsCandidates,
chatMentionRegex, chatMentionRegex,
encodeChatMentionText,
decodeChatMentionText, decodeChatMentionText,
}; };
View Options

lib/shared/updates/bad-device-token-spec.js

Show All 35 Lines
const userMentionsExtractionRegex = new RegExp( const userMentionsExtractionRegex = new RegExp(
`\\B(@(${oldValidUsernameRegexString}))\\b`, `\\B(@(${oldValidUsernameRegexString}))\\b`,
'g', 'g',
); );
const chatMentionRegexString = `^(?<!\\\\)(@\\[\\[([0-9,|]+):(${validChatNameRegexString}?)(?<!\\\\)\\]\\])`; const chatMentionRegexString = `^(?<!\\\\)(@\\[\\[([0-9,|]+):(${validChatNameRegexString}?)(?<!\\\\)\\]\\])`;
const chatMentionRegex: RegExp = new RegExp(chatMentionRegexString); const chatMentionRegex: RegExp = new RegExp(chatMentionRegexString);
function encodeChatMentionText(text: string): string {
return text.replace(/]/g, '\\]');
}
function decodeChatMentionText(text: string): string { function decodeChatMentionText(text: string): string {
return text.replace(/\\]/g, ']'); return text.replace(/\\]/g, ']');
} }
function extractUserMentionsFromText(text: string): string[] { function extractUserMentionsFromText(text: string): string[] {
const iterator = text.matchAll(userMentionsExtractionRegex); const iterator = text.matchAll(userMentionsExtractionRegex);
return [...iterator].map(matches => matches[2]); return [...iterator].map(matches => matches[2]);
} }
▲ Show 20 Lines • Show All 69 Lines • ▼ Show 20 Linesexport {
markdownUserMentionRegex, markdownUserMentionRegex,
isUserMentioned, isUserMentioned,
extractUserMentionsFromText, extractUserMentionsFromText,
getMentionTypeaheadUserSuggestions, getMentionTypeaheadUserSuggestions,
getNewTextAndSelection, getNewTextAndSelection,
getTypeaheadRegexMatches, getTypeaheadRegexMatches,
getUserMentionsCandidates, getUserMentionsCandidates,
chatMentionRegex, chatMentionRegex,
encodeChatMentionText,
decodeChatMentionText, decodeChatMentionText,
}; };
View Options

lib/shared/updates/delete-account-spec.js

Show All 35 Lines
const userMentionsExtractionRegex = new RegExp( const userMentionsExtractionRegex = new RegExp(
`\\B(@(${oldValidUsernameRegexString}))\\b`, `\\B(@(${oldValidUsernameRegexString}))\\b`,
'g', 'g',
); );
const chatMentionRegexString = `^(?<!\\\\)(@\\[\\[([0-9,|]+):(${validChatNameRegexString}?)(?<!\\\\)\\]\\])`; const chatMentionRegexString = `^(?<!\\\\)(@\\[\\[([0-9,|]+):(${validChatNameRegexString}?)(?<!\\\\)\\]\\])`;
const chatMentionRegex: RegExp = new RegExp(chatMentionRegexString); const chatMentionRegex: RegExp = new RegExp(chatMentionRegexString);
function encodeChatMentionText(text: string): string {
return text.replace(/]/g, '\\]');
}
function decodeChatMentionText(text: string): string { function decodeChatMentionText(text: string): string {
return text.replace(/\\]/g, ']'); return text.replace(/\\]/g, ']');
} }
function extractUserMentionsFromText(text: string): string[] { function extractUserMentionsFromText(text: string): string[] {
const iterator = text.matchAll(userMentionsExtractionRegex); const iterator = text.matchAll(userMentionsExtractionRegex);
return [...iterator].map(matches => matches[2]); return [...iterator].map(matches => matches[2]);
} }
▲ Show 20 Lines • Show All 69 Lines • ▼ Show 20 Linesexport {
markdownUserMentionRegex, markdownUserMentionRegex,
isUserMentioned, isUserMentioned,
extractUserMentionsFromText, extractUserMentionsFromText,
getMentionTypeaheadUserSuggestions, getMentionTypeaheadUserSuggestions,
getNewTextAndSelection, getNewTextAndSelection,
getTypeaheadRegexMatches, getTypeaheadRegexMatches,
getUserMentionsCandidates, getUserMentionsCandidates,
chatMentionRegex, chatMentionRegex,
encodeChatMentionText,
decodeChatMentionText, decodeChatMentionText,
}; };
View Options

lib/shared/updates/delete-thread-spec.js

Show All 35 Lines
const userMentionsExtractionRegex = new RegExp( const userMentionsExtractionRegex = new RegExp(
`\\B(@(${oldValidUsernameRegexString}))\\b`, `\\B(@(${oldValidUsernameRegexString}))\\b`,
'g', 'g',
); );
const chatMentionRegexString = `^(?<!\\\\)(@\\[\\[([0-9,|]+):(${validChatNameRegexString}?)(?<!\\\\)\\]\\])`; const chatMentionRegexString = `^(?<!\\\\)(@\\[\\[([0-9,|]+):(${validChatNameRegexString}?)(?<!\\\\)\\]\\])`;
const chatMentionRegex: RegExp = new RegExp(chatMentionRegexString); const chatMentionRegex: RegExp = new RegExp(chatMentionRegexString);
function encodeChatMentionText(text: string): string {
return text.replace(/]/g, '\\]');
}
function decodeChatMentionText(text: string): string { function decodeChatMentionText(text: string): string {
return text.replace(/\\]/g, ']'); return text.replace(/\\]/g, ']');
} }
function extractUserMentionsFromText(text: string): string[] { function extractUserMentionsFromText(text: string): string[] {
const iterator = text.matchAll(userMentionsExtractionRegex); const iterator = text.matchAll(userMentionsExtractionRegex);
return [...iterator].map(matches => matches[2]); return [...iterator].map(matches => matches[2]);
} }
▲ Show 20 Lines • Show All 69 Lines • ▼ Show 20 Linesexport {
markdownUserMentionRegex, markdownUserMentionRegex,
isUserMentioned, isUserMentioned,
extractUserMentionsFromText, extractUserMentionsFromText,
getMentionTypeaheadUserSuggestions, getMentionTypeaheadUserSuggestions,
getNewTextAndSelection, getNewTextAndSelection,
getTypeaheadRegexMatches, getTypeaheadRegexMatches,
getUserMentionsCandidates, getUserMentionsCandidates,
chatMentionRegex, chatMentionRegex,
encodeChatMentionText,
decodeChatMentionText, decodeChatMentionText,
}; };
View Options

lib/shared/updates/join-thread-spec.js

Loading...
View Options

lib/shared/updates/update-current-user-spec.js

Loading...
View Options

lib/shared/updates/update-entry-spec.js

Loading...
View Options

lib/shared/updates/update-spec.js

Loading...
View Options

lib/shared/updates/update-thread-read-status-spec.js

Loading...
View Options

lib/shared/updates/update-thread-spec.js

Loading...
View Options

lib/shared/updates/update-user-spec.js

Loading...