Introduce a const into specs defining which updates should be merged.
Depends on D9659
Details
Details
Generate some updates, reintroduce old code, and compare new with old result using _.isEqual.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| keyserver/src/creators/update-creator.js | ||
|---|---|---|
| 539–540 ↗ | (On Diff #32560) | I am not sure if it is possible to have updates that weren't listed in the previous condition, but if we need to add a check to early return when typesOfReplacedUpdatesForMatchingKey is null |
| lib/shared/updates/update-spec.js | ||
| 90–93 ↗ | (On Diff #32560) | same feedback as in: https://phab.comm.dev/D9658#inline-60808 |
| keyserver/src/creators/update-creator.js | ||
|---|---|---|
| 539–540 ↗ | (On Diff #32560) | We can't do that because if !currentUpdateInfo we want to keep an update regardless of its type - it means that it's the first update with this key and we don't want to replace it. |