Paths

Table of Contentst

Differential D9595

[Tunnelbroker] implement sending response after session creation attempt
ClosedPublic
Actions

Authored by kamil on Oct 25 2023, 4:03 AM.

Tags

None

Referenced Files

	F2898517: D9595.id32555.diff
	Sat, Oct 5, 3:30 AM

	F2898485: D9595.id32557.diff
	Sat, Oct 5, 3:24 AM

	Unknown Object (File)
	Wed, Oct 2, 1:07 PM

	Unknown Object (File)
	Wed, Oct 2, 1:07 PM

	Unknown Object (File)
	Wed, Oct 2, 1:07 PM

	Unknown Object (File)
	Wed, Oct 2, 1:07 PM

	Unknown Object (File)
	Wed, Oct 2, 1:07 PM

	Unknown Object (File)
	Wed, Oct 2, 1:07 PM

Subscribers

Details

Reviewers

michal
bartek
varun
• jon

Commits

rCOMMca4d5a621c73: [Tunnelbroker] implement sending response after session creation attempt

Summary

This code makes it possible to send a response after session init and makes changes in tests to adjust to the new flow.

Depends on D9594

Test Plan

Tunnelbroker tests (most important are test_tunnelbroker_invalid_auth and test_tunnelbroker_valid_auth).

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Oct 25 2023, 4:03 AM

kamil held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptOct 25 2023, 4:03 AM

Herald added subscribers: will, tomek, ashoat. · View Herald Transcript

kamil mentioned this in D9594: [Tunnelbroker] refactor initializing session to make it possible to send a response to the client on session creation failure.Oct 25 2023, 4:04 AM

Harbormaster failed remote builds in B23483: Diff 32391!Oct 25 2023, 4:07 AM

kamil published this revision for review.Oct 25 2023, 5:19 AM

add missing import

Harbormaster completed remote builds in B23485: Diff 32393.Oct 25 2023, 6:13 AM

kamil added a child revision: D9596: [lib] define Tunnelbroker API in Flow types.Oct 27 2023, 4:22 AM

michal accepted this revision.Oct 30 2023, 5:50 AM

michal added inline comments.

services/tunnelbroker/src/websockets/mod.rs
193 ↗	(On Diff #32393)	Not sure if you agree but I would prefer to call it the same as in the argument to the `initiate_session` so it's more clearer that it's the same object.

This revision is now accepted and ready to land.Oct 30 2023, 5:50 AM

tx -> outgoing

Harbormaster failed remote builds in B23606: Diff 32549!Oct 31 2023, 8:17 AM

CI

CI v2

Harbormaster failed remote builds in B23612: Diff 32555!Oct 31 2023, 9:09 AM

Harbormaster completed remote builds in B23614: Diff 32557.Oct 31 2023, 9:59 AM

rebase

Harbormaster completed remote builds in B23769: Diff 32731.Nov 6 2023, 2:30 AM

Closed by commit rCOMMca4d5a621c73: [Tunnelbroker] implement sending response after session creation attempt (authored by kamil). · Explain WhyNov 6 2023, 8:29 AM

This revision was automatically updated to reflect the committed changes.

kamil mentioned this in rCOMM2c269eb01013: [Tunnelbroker] refactor initializing session to make it possible to send a….

kamil added a commit: rCOMMca4d5a621c73: [Tunnelbroker] implement sending response after session creation attempt.

Revision Contents
Changeset List

Path

Size

services/

commtest/

src/

tunnelbroker/

19 lines

tests/

identity_tunnelbroker_tests.rs

14 lines

tunnelbroker_integration_tests.rs

6 lines

tunnelbroker_persist_tests.rs

6 lines

tunnelbroker_recipient_confirmation_tests.rs

22 lines

tunnelbroker_sender_confirmation_tests.rs

8 lines

tunnelbroker_websocket_messages_tests.rs

4 lines

tunnelbroker/

src/

websockets/

50 lines

Diff 32800

services/commtest/src/tunnelbroker/socket.rs

Loading...

services/commtest/tests/identity_tunnelbroker_tests.rs

Loading...

services/commtest/tests/tunnelbroker_integration_tests.rs

Loading...

services/commtest/tests/tunnelbroker_persist_tests.rs

Loading...

services/commtest/tests/tunnelbroker_recipient_confirmation_tests.rs

Loading...

services/commtest/tests/tunnelbroker_sender_confirmation_tests.rs

Loading...

services/commtest/tests/tunnelbroker_websocket_messages_tests.rs

Loading...

services/tunnelbroker/src/websockets/mod.rs

Loading...