Details

Reviewers

michal
bartek
rohan

Commits

rCOMM7053a0f8c5be: [keyserver] Add a function that deletes a blob

Summary

This function calls an endpoint of Blob service that deletes a blob.

Depends on D9944

Test Plan

Create a blob and delete it - check if a holder is deleted.

Diff Detail

Repository

rCOMM Comm

Branch

linki

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Nov 24 2023, 2:48 PM

Herald added a subscriber: ashoat. · View Herald TranscriptNov 24 2023, 2:48 PM

Harbormaster completed remote builds in B24387: Diff 33586.Nov 24 2023, 3:08 PM

tomek requested review of this revision.Nov 24 2023, 3:08 PM

tomek added a child revision: D9968: [keyserver] Fetch invite link blob holder.Nov 24 2023, 4:14 PM

rohan accepted this revision.Nov 24 2023, 6:42 PM

This revision is now accepted and ready to land.Nov 24 2023, 6:42 PM

Use a param object instead of two args for hash and holder to avoid the confusion between them

Harbormaster completed remote builds in B24640: Diff 34052.Nov 30 2023, 3:11 PM

Destructure params inside function

Set instant flag

Harbormaster completed remote builds in B26336: Diff 36404.Jan 31 2024, 4:57 PM

Harbormaster completed remote builds in B26338: Diff 36406.Jan 31 2024, 5:05 PM

bartek accepted this revision.Feb 7 2024, 10:05 AM

bartek added inline comments.

keyserver/src/services/blob.js
103–105 ↗	(On Diff #36406)	Before landing, could you update this diff to use the function from D10908?

Use auth headers

keyserver/src/services/blob.js
103–105 ↗	(On Diff #36406)	Sure!

Harbormaster completed remote builds in B26649: Diff 36846.Feb 8 2024, 2:47 PM

Closed by commit rCOMM7053a0f8c5be: [keyserver] Add a function that deletes a blob. · Explain WhyFeb 14 2024, 3:58 PM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM7053a0f8c5be: [keyserver] Add a function that deletes a blob.

[keyserver] Add a function that deletes a blob
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 33586

keyserver/src/services/blob.js

[keyserver] Add a function that deletes a blobClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 33586

keyserver/src/services/blob.js

[keyserver] Add a function that deletes a blob
ClosedPublic
Actions

Revision Contents
Changeset List