Page MenuHomePhabricator
Differential D10089

[web] introduce on click remove keyserver functionality
ClosedPublic
Actions

Authored by ginsu on Nov 28 2023, 8:57 PM.
Tags
None
Referenced Files
F3387369: D10089.id34022.diff
Fri, Nov 29, 9:05 AM
F3387052: D10089.diff
Fri, Nov 29, 7:26 AM
Unknown Object (File)
Mon, Nov 25, 10:59 PM
Unknown Object (File)
Tue, Nov 12, 11:30 AM
Unknown Object (File)
Sat, Nov 2, 1:40 AM
Unknown Object (File)
Wed, Oct 30, 11:24 PM
Unknown Object (File)
Oct 15 2024, 3:21 AM
Unknown Object (File)
Oct 2 2024, 4:38 AM
View All 61 Files
Subscribers
ashoat
tomek

Details

Reviewers
rohan
inka
michal
Commits
rCOMM2a9f5f4b299c: [web] introduce on click remove keyserver functionality
Summary

This diff introduces onDeleteKeyserver callback which is fired whenever the delete keyserver button is clicked

For context here are the designs for what the user flow should look like:

Screenshot 2023-11-28 at 11.59.08 PM.png (750×3 px, 364 KB)

Linear task: https://linear.app/comm/issue/ENG-5498/introduce-onpress-remove-selected-keyserver-function

Depends on D10081

Test Plan

Please see the demo video below

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Nov 28 2023, 8:57 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 28 2023, 8:57 PM
ginsu edited the summary of this revision. (Show Details)Nov 28 2023, 9:02 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: rohan, inka, michal.
ginsu added a parent revision: D10081: [web] introduce confirmation alert component.
ginsu attached a referenced file: F900908: Screenshot 2023-11-28 at 11.59.08 PM.png. (Show Details)
Harbormaster completed remote builds in B24597: Diff 33976.Nov 28 2023, 10:18 PM
ginsu requested review of this revision.Nov 28 2023, 10:18 PM
ginsu added a child revision: D10090: [lib/native] lift set custom server action type into lib.Nov 29 2023, 12:50 AM
rohan accepted this revision.Nov 29 2023, 4:05 AM
This revision is now accepted and ready to land.Nov 29 2023, 4:05 AM
ginsu updated this revision to Diff 34022.Nov 29 2023, 10:03 PM

rebase before landing

Harbormaster completed remote builds in B24621: Diff 34022.Nov 29 2023, 10:30 PM
Closed by commit rCOMM2a9f5f4b299c: [web] introduce on click remove keyserver functionality (authored by ginsu). · Explain WhyNov 29 2023, 10:42 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM2a9f5f4b299c: [web] introduce on click remove keyserver functionality.

Revision Contents
Changeset List

PathSize
web/
modals/
keyserver-selection/
8 lines
46 lines

Diff 33976

View Options

web/modals/keyserver-selection/keyserver-selection-modal.css

Loading...
View Options

web/modals/keyserver-selection/keyserver-selection-modal.react.js

Loading...