[web] implement onClickAddKeyserver callback
ClosedPublic
Actions

Authored by ginsu on Nov 29 2023, 1:55 AM.

Details

Reviewers

inka
michal
rohan

Commits

rCOMM7cfdb6216480: [web] implement onClickAddKeyserver callback

Summary

When a user clicks on the add keyserver button their keyserver should be stored in the keyserver store. onClickAddKeyserver handles this functionality. Additionally, if the user is a staff or in dev mode, we want the input field to be pre-populated with the value of customServer

Linear task: https://linear.app/comm/issue/ENG-4726/dispatch-add-keyserver-redux-action-when-onpress-save-button-is

Depends on D10093

Test Plan

Please see the demo video below

Diff Detail

Repository

rCOMM Comm

Branch

eng-5189 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Nov 29 2023, 1:55 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 29 2023, 1:55 AM

ginsu edited the summary of this revision. (Show Details)Nov 29 2023, 1:57 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: inka, rohan, michal.

ginsu added a parent revision: D10093: [web] save the recently deleted server url to customServer redux state.

ginsu attached a referenced file: F901280: Screen Recording 2023-11-29 at 4.41.38 AM.mov. (Show Details)

Harbormaster completed remote builds in B24607: Diff 33986.Nov 29 2023, 2:20 AM

ginsu requested review of this revision.Nov 29 2023, 2:20 AM

Looks good to me. Would be nice if someone else can take a look at the newKeyserverInfo though since I'm not really familiar with what the default values should be

This revision is now accepted and ready to land.Nov 29 2023, 6:20 PM

rohan resigned from this revision.Nov 29 2023, 6:20 PM

This revision now requires review to proceed.Nov 29 2023, 6:20 PM

inka accepted this revision.Nov 30 2023, 2:48 AM

This revision is now accepted and ready to land.Nov 30 2023, 2:48 AM

ginsu added a child revision: D10154: [web] add keyserver url validation logic and error handling to the add keyserver modal.Dec 4 2023, 6:48 AM

rebase before landing

This revision was landed with ongoing or failed builds.Dec 4 2023, 11:02 PM

Closed by commit rCOMM7cfdb6216480: [web] implement onClickAddKeyserver callback (authored by ginsu). · Explain Why

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM7cfdb6216480: [web] implement onClickAddKeyserver callback.

Harbormaster completed remote builds in B24789: Diff 34254.Dec 4 2023, 11:49 PM