Page MenuHomePhabricator
Differential D10080

[web] introduce temp onClickDisconnectKeyserver
ClosedPublic
Actions

Authored by ginsu on Nov 28 2023, 8:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 1, 11:55 AM
Unknown Object (File)
Wed, Oct 30, 11:24 PM
Unknown Object (File)
Oct 2 2024, 1:52 AM
Unknown Object (File)
Oct 2 2024, 1:52 AM
Unknown Object (File)
Oct 2 2024, 1:52 AM
Unknown Object (File)
Oct 2 2024, 1:52 AM
Unknown Object (File)
Oct 2 2024, 1:51 AM
Unknown Object (File)
Oct 2 2024, 1:51 AM
View All 66 Files
Subscribers
ashoat
tomek

Details

Reviewers
inka
michal
rohan
Commits
rCOMM8571cfe07878: [web] introduce temp onClickDisconnectKeyserver
Summary

As of Nov 2023, disconnecting from a keyserver is outside the scope of the keyserver selection screen. However, we currently have the UI for this already implemented so as a temporary solution this diff has the onClickDisconnectKeyserver callback display an alert to the user, informing them that this feature is not quite ready yet

Depends on D10079

Test Plan

Please see the demo video below

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Nov 28 2023, 8:25 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 28 2023, 8:25 PM
ginsu edited the summary of this revision. (Show Details)Nov 28 2023, 8:29 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: inka, michal, rohan.
ginsu added a parent revision: D10079: [web] update the keyserver selection modal based on the connection status.
ginsu updated this revision to Diff 33967.Nov 28 2023, 8:31 PM

update

Harbormaster completed remote builds in B24587: Diff 33966.Nov 28 2023, 8:45 PM
Harbormaster completed remote builds in B24588: Diff 33967.Nov 28 2023, 8:53 PM
ginsu requested review of this revision.Nov 28 2023, 8:53 PM
ginsu added a child revision: D10081: [web] introduce confirmation alert component.Nov 28 2023, 8:53 PM
rohan accepted this revision.Nov 29 2023, 3:50 AM
rohan added inline comments.
web/modals/keyserver-selection/keyserver-selection-modal.react.js
26–35 ↗(On Diff #33967)
This revision is now accepted and ready to land.Nov 29 2023, 3:50 AM
ginsu updated this revision to Diff 34020.Nov 29 2023, 9:57 PM

address comments + rebase before landing

Harbormaster completed remote builds in B24619: Diff 34020.Nov 29 2023, 10:16 PM
Closed by commit rCOMM8571cfe07878: [web] introduce temp onClickDisconnectKeyserver (authored by ginsu). · Explain WhyNov 29 2023, 10:42 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM8571cfe07878: [web] introduce temp onClickDisconnectKeyserver.

Revision Contents
Changeset List

PathSize
web/
modals/
keyserver-selection/
19 lines

Diff 34020

View Options

web/modals/keyserver-selection/keyserver-selection-modal.react.js

Loading...