Page MenuHomePhabricator

[web] Update existing checks on isDefault in role-actions-menu.reactjs
ClosedPublic

Authored by atul on Nov 30 2023, 1:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 6:35 PM
Unknown Object (File)
Tue, Nov 26, 12:00 PM
Unknown Object (File)
Tue, Nov 26, 10:02 AM
Unknown Object (File)
Nov 23 2024, 2:48 AM
Unknown Object (File)
Nov 22 2024, 10:42 PM
Unknown Object (File)
Nov 22 2024, 10:35 PM
Unknown Object (File)
Nov 22 2024, 11:07 AM
Unknown Object (File)
Nov 21 2024, 3:06 AM
Subscribers

Details

Summary

We now want to make sure that we get rid of checks on role.isDefault and replace them with checks on role.specialRole:

  • For default roles, this is `role.specialRole === ${specialRoles.DEFAULT_ROLE}
  • For admin roles, this is `role.specialRole === ${specialRoles.ADMIN_ROLE}

Part of ENG-5993

This diff handles role-actions-menu.react.js

Depends on D10118

Test Plan

Confirmed the use of roleIsDefaultRole had no change on the results in the code

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

rohan held this revision as a draft.
rohan published this revision for review.Nov 30 2023, 1:34 PM
This revision is now accepted and ready to land.Dec 4 2023, 12:28 AM
atul edited reviewers, added: rohan; removed: atul.