Page MenuHomePhabricator

[keyserver] Create a blob while adding / editing an invite link
ClosedPublic

Authored by tomek on Dec 1 2023, 6:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 16, 7:41 PM
Unknown Object (File)
Sat, Nov 16, 4:34 AM
Unknown Object (File)
Fri, Nov 15, 3:28 PM
Unknown Object (File)
Thu, Nov 14, 10:22 PM
Unknown Object (File)
Thu, Nov 14, 9:09 PM
Unknown Object (File)
Fri, Nov 1, 9:00 PM
Unknown Object (File)
Tue, Oct 29, 11:18 AM
Unknown Object (File)
Oct 7 2024, 7:03 AM
Subscribers

Details

Summary

Every time we're creating / updating a link, we need to make sure that the blob is created.
We start with blob creation because it is a shared place between keyservers and links should be globally unique - a keyserver should first check if a blob can be created which means that other keyservers haven't used that link.

Depends on D10131

Test Plan

Create a link and check if a correct blob is created.
Update a link and check if a blob is created and an old blob holder is deleted.

Diff Detail

Repository
rCOMM Comm
Branch
linki
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Delete unnecessary export

tomek requested review of this revision.Dec 1 2023, 7:22 AM

Looks good to me, but it would be nice if someone with more context on this could take a look as well

This revision is now accepted and ready to land.Dec 5 2023, 8:29 AM
tomek planned changes to this revision.Dec 6 2023, 1:44 AM

I'm going to check the option of using MariaDB transactions to minimize the number of possible race conditions

This revision is now accepted and ready to land.Feb 1 2024, 6:47 AM

I'm going to check the option of using MariaDB transactions to minimize the number of possible race conditions

Not sure which idea I was investigating, but I remember concluding that introducing transactions would cause even more issues.