Paths

Table of Contentst

-
keyserver/src/fetchers/
-
src/
-
fetchers/
-
link-fetchers.js

[keyserver] Introduce a function that allows fetching all the primary links
ClosedPublic
Actions

Authored by tomek on Dec 4 2023, 4:37 AM.

Details

Reviewers

michal
bartek
rohan

Commits

rCOMMe4890d882eee: [keyserver] Introduce a function that allows fetching all the primary links

Summary

Currently we're fetching only the links for communities where a viewer is a member. For the migration to work we need to be able to fetch all the links - this diff introduces a function that allows it.

Depends on D10134

Test Plan

Check if in the web app we're receiving only the links for communities where a viewer is a member.
Check if calling fetchAllPrimaryInviteLinks returns all the links.

Diff Detail

Repository

rCOMM Comm

Branch

linki

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Dec 4 2023, 4:37 AM

Herald added a subscriber: ashoat. · View Herald TranscriptDec 4 2023, 4:37 AM

Harbormaster completed remote builds in B24721: Diff 34178.Dec 4 2023, 4:56 AM

tomek requested review of this revision.Dec 4 2023, 4:56 AM

This feels pretty messy. I'm not sure what the callstack looks like, but is it possible to introduce a second function for this (with shared code factored out) instead of overloading fetchPrimaryInviteLinks to handle two different scenarios?

In D10150#295223, @ashoat wrote:

This feels pretty messy. I'm not sure what the callstack looks like, but is it possible to introduce a second function for this (with shared code factored out) instead of overloading fetchPrimaryInviteLinks to handle two different scenarios?

Yeah, I can do that. Shouldn't matter too much at the call sites.

Split a function into two

tomek edited the summary of this revision. (Show Details)Dec 4 2023, 6:47 AM

tomek edited the test plan for this revision. (Show Details)

tomek retitled this revision from [keyserver] Fetch all the links when a viewer is a script viewer to [keyserver] Introduce a function that allows fetching all the primary links.

Thank you!!

Harbormaster completed remote builds in B24728: Diff 34185.Dec 4 2023, 7:34 AM

rohan accepted this revision.Dec 5 2023, 8:24 AM

This revision is now accepted and ready to land.Dec 5 2023, 8:24 AM

tomek added a child revision: D10205: [keyserver] Add a function that synchronizes keyserver's invite links with blobs.Dec 6 2023, 6:13 AM

Rebase

Harbormaster completed remote builds in B26414: Diff 36524.Feb 1 2024, 7:28 AM

Closed by commit rCOMMe4890d882eee: [keyserver] Introduce a function that allows fetching all the primary links (authored by tomek). · Explain WhyFeb 14 2024, 7:58 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMe4890d882eee: [keyserver] Introduce a function that allows fetching all the primary links.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

fetchers/

link-fetchers.js

16 lines

Diff 34178

View Options

keyserver/src/fetchers/link-fetchers.js

// @flow		// @flow

import invariant from 'invariant';		import invariant from 'invariant';
import _debounce from 'lodash/debounce.js';		import _debounce from 'lodash/debounce.js';
import * as React from 'react';		import * as React from 'react';

import { useModalContext } from 'lib/components/modal-provider.react.js';		import { useModalContext } from 'lib/components/modal-provider.react.js';
		import SWMansionIcon from 'lib/components/SWMansionIcon.react.js';
import type { ChatMessageInfoItem } from 'lib/selectors/chat-selectors.js';		import type { ChatMessageInfoItem } from 'lib/selectors/chat-selectors.js';
		import { useCanEditMessage } from 'lib/shared/edit-messages-utils.js';
import { createMessageReply } from 'lib/shared/message-utils.js';		import { createMessageReply } from 'lib/shared/message-utils.js';
import { useCanCreateReactionFromMessage } from 'lib/shared/reaction-utils.js';		import { useCanCreateReactionFromMessage } from 'lib/shared/reaction-utils.js';
import {		import {
threadHasPermission,		threadHasPermission,
useSidebarExistsOrCanBeCreated,		useSidebarExistsOrCanBeCreated,
} from 'lib/shared/thread-utils.js';		} from 'lib/shared/thread-utils.js';
import { messageTypes } from 'lib/types/message-types-enum.js';		import { messageTypes } from 'lib/types/message-types-enum.js';
import { isComposableMessageType } from 'lib/types/message-types.js';		import { isComposableMessageType } from 'lib/types/message-types.js';
▲ Show 20 Lines • Show All 202 Lines • ▼ Show 20 Lines	return React.useMemo(() => {
return {		return {
actionButtonContent: buttonContent,		actionButtonContent: buttonContent,
onClick: onClickTogglePin,		onClick: onClickTogglePin,
label: isPinned ? 'Unpin' : 'Pin',		label: isPinned ? 'Unpin' : 'Pin',
};		};
}, [canTogglePin, inputState, isPinned, pushModal, item, threadInfo]);		}, [canTogglePin, inputState, isPinned, pushModal, item, threadInfo]);
}		}

		function useMessageEditAction(
		item: ChatMessageInfoItem,
		threadInfo: ThreadInfo,
		): ?MessageTooltipAction {
		const { messageInfo } = item;

		const canEditMessage = useCanEditMessage(threadInfo, messageInfo);

		return React.useMemo(() => {
		if (!canEditMessage) {
		return null;
		}
		const buttonContent = (
		<SWMansionIcon icon="edit-1" size={18} disableFill={false} />
		);
		const onClickEdit = () => {
		// TODO: Enter edit mode
		};
		return {
		actionButtonContent: buttonContent,
		onClick: onClickEdit,
		label: 'Edit',
		};
		}, [canEditMessage]);
		}

function useMessageTooltipActions(		function useMessageTooltipActions(
item: ChatMessageInfoItem,		item: ChatMessageInfoItem,
threadInfo: ThreadInfo,		threadInfo: ThreadInfo,
): $ReadOnlyArray<MessageTooltipAction> {		): $ReadOnlyArray<MessageTooltipAction> {
const sidebarAction = useMessageTooltipSidebarAction(item, threadInfo);		const sidebarAction = useMessageTooltipSidebarAction(item, threadInfo);
const replyAction = useMessageTooltipReplyAction(item, threadInfo);		const replyAction = useMessageTooltipReplyAction(item, threadInfo);
const copyAction = useMessageCopyAction(item);		const copyAction = useMessageCopyAction(item);
const reactAction = useMessageReactAction(item, threadInfo);		const reactAction = useMessageReactAction(item, threadInfo);
const togglePinAction = useMessageTogglePinAction(item, threadInfo);		const togglePinAction = useMessageTogglePinAction(item, threadInfo);
		const editAction = useMessageEditAction(item, threadInfo);
return React.useMemo(		return React.useMemo(
() =>		() =>
[		[
replyAction,		replyAction,
sidebarAction,		sidebarAction,
copyAction,		copyAction,
reactAction,		reactAction,
togglePinAction,		togglePinAction,
		editAction,
].filter(Boolean),		].filter(Boolean),
[replyAction, sidebarAction, copyAction, reactAction, togglePinAction],		[
		replyAction,
		sidebarAction,
		copyAction,
		reactAction,
		togglePinAction,
		editAction,
		],
);		);
}		}

type UseMessageTooltipArgs = {		type UseMessageTooltipArgs = {
+availablePositions: $ReadOnlyArray<TooltipPosition>,		+availablePositions: $ReadOnlyArray<TooltipPosition>,
+item: ChatMessageInfoItem,		+item: ChatMessageInfoItem,
+threadInfo: ThreadInfo,		+threadInfo: ThreadInfo,
};		};
▲ Show 20 Lines • Show All 187 Lines • Show Last 20 Lines

[keyserver] Introduce a function that allows fetching all the primary linksClosedPublicActions