[web] await baseSetThreadAvatar/baseSetUserAvatar in onImageSelected
ClosedPublic
Actions

Authored by ashoat on Dec 4 2023, 1:17 PM.

Details

Reviewers

atul
ginsu
michal

Commits

rCOMM1f86a1b1dc52: [web] await baseSetThreadAvatar/baseSetUserAvatar in onImageSelected

Summary

We could add a void here instead, but onImageSelected is already an async function, and the place we're passing it to doesn't await the result anyways. So might as well just add an await keyword.

Depends on D10174

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Dec 4 2023, 1:17 PM

Herald added a subscriber: tomek. · View Herald TranscriptDec 4 2023, 1:17 PM

ashoat added a child revision: D10176: [lib][native][web][landing] Silence unused-promise using void keyword.Dec 4 2023, 1:17 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 4 2023, 1:50 PM

Harbormaster failed remote builds in B24754: Diff 34217!

Rebase

ashoat published this revision for review.Dec 4 2023, 6:27 PM

Harbormaster completed remote builds in B24770: Diff 34233.Dec 4 2023, 7:33 PM

ginsu accepted this revision.Dec 4 2023, 9:50 PM

This revision is now accepted and ready to land.Dec 4 2023, 9:50 PM

Closed by commit rCOMM1f86a1b1dc52: [web] await baseSetThreadAvatar/baseSetUserAvatar in onImageSelected (authored by ashoat). · Explain WhyDec 5 2023, 12:33 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM1f86a1b1dc52: [web] await baseSetThreadAvatar/baseSetUserAvatar in onImageSelected.

Revision Contents
Changeset List

Path

Size

web/

avatars/

edit-thread-avatar-menu.react.js

2 lines

edit-user-avatar-menu.react.js

2 lines

Diff 34217

View Options

web/avatars/edit-thread-avatar-menu.react.js