Page MenuHomePhabricator

[web] implement onClickAddKeyserver callback
ClosedPublic

Authored by ginsu on Nov 29 2023, 1:55 AM.
Tags
None
Referenced Files
F3184795: D10094.id33986.diff
Fri, Nov 8, 11:59 AM
F3184733: D10094.id34260.diff
Fri, Nov 8, 11:45 AM
F3184697: D10094.id34254.diff
Fri, Nov 8, 11:35 AM
F3183642: D10094.diff
Fri, Nov 8, 9:49 AM
Unknown Object (File)
Sat, Nov 2, 2:36 AM
Unknown Object (File)
Wed, Oct 30, 11:24 PM
Unknown Object (File)
Mon, Oct 28, 8:52 AM
Unknown Object (File)
Oct 2 2024, 1:08 AM
Subscribers

Details

Summary

When a user clicks on the add keyserver button their keyserver should be stored in the keyserver store. onClickAddKeyserver handles this functionality. Additionally, if the user is a staff or in dev mode, we want the input field to be pre-populated with the value of customServer

Linear task: https://linear.app/comm/issue/ENG-4726/dispatch-add-keyserver-redux-action-when-onpress-save-button-is

Depends on D10093

Test Plan

Please see the demo video below

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu requested review of this revision.Nov 29 2023, 2:20 AM

Looks good to me. Would be nice if someone else can take a look at the newKeyserverInfo though since I'm not really familiar with what the default values should be

This revision is now accepted and ready to land.Nov 29 2023, 6:20 PM
This revision now requires review to proceed.Nov 29 2023, 6:20 PM
This revision is now accepted and ready to land.Nov 30 2023, 2:48 AM
This revision was landed with ongoing or failed builds.Dec 4 2023, 11:02 PM
This revision was automatically updated to reflect the committed changes.