Page MenuHomePhabricator

[keyserver][lib] handleAsyncPromise -> ignorePromiseRejections
ClosedPublic

Authored by ashoat on Dec 4 2023, 1:08 PM.
Tags
None
Referenced Files
F3367706: D10158.id34293.diff
Mon, Nov 25, 3:53 PM
Unknown Object (File)
Sat, Nov 23, 4:32 PM
Unknown Object (File)
Fri, Nov 22, 2:41 AM
Unknown Object (File)
Tue, Nov 19, 9:31 PM
Unknown Object (File)
Tue, Nov 19, 7:27 PM
Unknown Object (File)
Fri, Nov 8, 6:20 AM
Unknown Object (File)
Thu, Nov 7, 8:35 PM
Unknown Object (File)
Oct 16 2024, 10:30 PM
Subscribers

Details

Summary

As part of enabling the unused-promise Flow lint (ENG-5907), I want to make two changes to this function:

  1. Renaming it to ignorePromiseRejections. I think this captures what it does much better.
  2. Move it to lib. The Lint exposed some issues in lib utilities that we use from keyserver, and to fix those we'll want access to ignorePromiseRejections from lib.
Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable