Page MenuHomePhabricator

[keyserver] Ignore potential to crash on promise rejections in keyserver preamble
ClosedPublic

Authored by ashoat on Dec 4 2023, 1:19 PM.
Tags
None
Referenced Files
F3343554: D10179.diff
Fri, Nov 22, 3:09 AM
Unknown Object (File)
Thu, Nov 7, 5:09 AM
Unknown Object (File)
Oct 16 2024, 2:34 AM
Unknown Object (File)
Oct 16 2024, 2:34 AM
Unknown Object (File)
Oct 16 2024, 2:34 AM
Unknown Object (File)
Oct 16 2024, 2:34 AM
Unknown Object (File)
Oct 16 2024, 2:34 AM
Unknown Object (File)
Sep 29 2024, 6:01 PM
Subscribers

Details

Summary

We use an async IIFE in lieu of top-level await (which Flow doesn't support) to initialize the keyserver.

In most cases we don't want to crash on promise rejections in keyserver. But if we encounter an error in the preamble, we should probably crash, since it indicates that the keyserver is not able to initialize itself.

This diff doesn't change any behavior. We're just using the void keyword to silence the unused-promise Lint, which is recommended by the Flow team. See the "Fire-and-forget" part of this blog post.

Depends on D10178

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable