Page MenuHomePhabricator

[web] Update existing checks on isDefault in role-actions-menu.reactjs
ClosedPublic

Authored by atul on Nov 30 2023, 1:22 PM.
Tags
None
Referenced Files
F6273922: D10119.diff
Fri, Apr 25, 4:58 PM
F6241302: D10119.diff
Fri, Apr 25, 12:36 AM
Unknown Object (File)
Tue, Apr 22, 1:13 PM
Unknown Object (File)
Thu, Apr 17, 11:33 PM
Unknown Object (File)
Thu, Apr 17, 9:32 AM
Unknown Object (File)
Thu, Apr 17, 7:08 AM
Unknown Object (File)
Thu, Apr 17, 2:45 AM
Unknown Object (File)
Thu, Apr 17, 2:21 AM
Subscribers

Details

Summary

We now want to make sure that we get rid of checks on role.isDefault and replace them with checks on role.specialRole:

  • For default roles, this is `role.specialRole === ${specialRoles.DEFAULT_ROLE}
  • For admin roles, this is `role.specialRole === ${specialRoles.ADMIN_ROLE}

Part of ENG-5993

This diff handles role-actions-menu.react.js

Depends on D10118

Test Plan

Confirmed the use of roleIsDefaultRole had no change on the results in the code

Diff Detail

Repository
rCOMM Comm
Branch
special_role
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

rohan held this revision as a draft.
rohan published this revision for review.Nov 30 2023, 1:34 PM
This revision is now accepted and ready to land.Dec 4 2023, 12:28 AM
atul edited reviewers, added: rohan; removed: atul.