[native][web] Add a context provider on native that exposes notifications session creator
ClosedPublic
Actions

Authored by tomek on Jan 17 2024, 3:59 PM.

Details

Reviewers

varun
marcin
inka
kamil

Commits

rCOMMbf1ff1e5e8ff: [native][web] Add a context provider on native that exposes notifications…

Summary

This makes it more convenient to use this function on both platforms.

Depends on D10662

Test Plan

Check if encrypted notifs work on iOS and web.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Jan 17 2024, 3:59 PM

tomek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJan 17 2024, 3:59 PM

tomek edited the summary of this revision. (Show Details)Jan 17 2024, 4:00 PM

tomek added a parent revision: D10662: [web] Introduce deviceID parameter to initial notif message function.

tomek added a child revision: D10664: [native][web] Make identity client mandatory.Jan 17 2024, 4:03 PM

Harbormaster completed remote builds in B25836: Diff 35725.Jan 17 2024, 4:19 PM

tomek published this revision for review.Jan 17 2024, 4:51 PM

tomek retitled this revision from [native][web] Add a context provider on web that exposes notifications session creator to [native][web] Add a context provider on native that exposes notifications session creator.Jan 17 2024, 5:04 PM

kamil accepted this revision.Jan 18 2024, 5:50 PM

kamil added inline comments.

web/root.js
47 ↗	(On Diff #35725)	the previous order was more readable I think - don't see any dependency why to force `IdentityServiceContextProvider` to be nested but leaving this up to you