Page MenuHomePhabricator
Differential D10764

[identity] Store social proof in users table
ClosedPublic
Actions

Authored by bartek on Jan 22 2024, 3:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 22, 4:29 AM
Unknown Object (File)
Tue, Apr 22, 4:08 AM
Unknown Object (File)
Mon, Apr 21, 8:32 PM
Unknown Object (File)
Mon, Apr 21, 2:57 AM
Unknown Object (File)
Sun, Apr 6, 8:58 AM
Unknown Object (File)
Mar 12 2025, 7:41 PM
Unknown Object (File)
Mar 12 2025, 4:17 AM
Unknown Object (File)
Feb 20 2025, 9:49 PM
View All 80 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
michal
will
Commits
rCOMMb172225d3ce4: [identity] Store social proof in users table
Summary

Part 1 of ENG-6480.
When wallet user is being registered, we should store the social proof in the users table.

Depends on D10762

Test Plan

Called LogInWalletUser RPC and checked (awslocal dynamodb scan) that the social proof is stored in the users table.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Jan 22 2024, 3:06 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 22 2024, 3:06 AM
bartek added a child revision: D10765: [identity] Remove social proof from devices table.Jan 22 2024, 3:08 AM
Harbormaster completed remote builds in B25987: Diff 35919.Jan 22 2024, 3:43 AM
bartek published this revision for review.Jan 22 2024, 3:47 AM
bartek added inline comments.
services/identity/src/constants.rs
51–52

previous name was misleading, especially since we no longer have the "devices" map attribute

varun accepted this revision.Jan 22 2024, 6:04 PM
This revision is now accepted and ready to land.Jan 22 2024, 6:04 PM
Closed by commit rCOMMb172225d3ce4: [identity] Store social proof in users table (authored by bartek). · Explain WhyJan 26 2024, 8:33 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMb172225d3ce4: [identity] Store social proof in users table.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
3 lines
24 lines
6 lines

Diff 35919

View Options

services/identity/src/constants.rs

Show First 20 Lines • Show All 240 Lines • ▼ Show 20 Lines const messageDatas = userIDs.map(otherUserID => ({
creatorID: viewer.userID, creatorID: viewer.userID,
creatorFID: viewerFID, creatorFID: viewerFID,
targetID: otherUserID, targetID: otherUserID,
targetFID: request.userIDsToFID[otherUserID], targetFID: request.userIDsToFID[otherUserID],
time: now, time: now,
operation: 'farcaster_mutual', operation: 'farcaster_mutual',
})); }));
await createMessages(viewer, messageDatas, 'broadcast'); await createMessages(viewer, messageDatas, 'broadcast');
} else if (request.action === relationshipActions.ACKNOWLEDGE) {
updateIDs.push(...userIDs);
const insertRows = userIDs.map(userID => {
const [user1, user2] = sortUserIDs(viewer.userID, userID);
return { user1, user2, status: undirectedStatus.KNOW_OF };
});
const updateDatas = await updateChangedUndirectedRelationships(insertRows);
inkaAuthorUnsubmitted
Done
Inline Actions

updateChangedUndirectedRelationships only updates the relationship if there was none, or the relationship status provided it greater than the one in the db. This will not be the case here, because KNOW_OF is 0-the lowest possible value. So we will not override a more meaningful relationship.

inka: `updateChangedUndirectedRelationships` only updates the relationship if there was none, or the…
tomekUnsubmitted
Not Done
Inline Actions

Makes sense, but is there an easy way of checking if the relationship doesn't need to be updated?

tomek: Makes sense, but is there an easy way of checking if the relationship doesn't need to be…
inkaAuthorUnsubmitted
Done
Inline Actions

The only thing this function does is checking if the relationship needs to be updated, and if so updates it. So I don't think it makes sense to duplicate this logic.
We discussed this offline and agreed that this code makes sense and can be left as is.

inka: The only thing this function does is checking if the relationship needs to be updated, and if…
await createUpdates(updateDatas);
} else { } else {
invariant( invariant(
false, false,
`action ${request.action} is invalid or not supported currently`, `action ${request.action} is invalid or not supported currently`,
); );
} }
await createUpdates( await createUpdates(
▲ Show 20 Lines • Show All 169 Lines • Show Last 20 Lines
View Options

services/identity/src/database.rs

Show First 20 Lines • Show All 240 Lines • ▼ Show 20 Lines const messageDatas = userIDs.map(otherUserID => ({
creatorID: viewer.userID, creatorID: viewer.userID,
creatorFID: viewerFID, creatorFID: viewerFID,
targetID: otherUserID, targetID: otherUserID,
targetFID: request.userIDsToFID[otherUserID], targetFID: request.userIDsToFID[otherUserID],
time: now, time: now,
operation: 'farcaster_mutual', operation: 'farcaster_mutual',
})); }));
await createMessages(viewer, messageDatas, 'broadcast'); await createMessages(viewer, messageDatas, 'broadcast');
} else if (request.action === relationshipActions.ACKNOWLEDGE) {
updateIDs.push(...userIDs);
const insertRows = userIDs.map(userID => {
const [user1, user2] = sortUserIDs(viewer.userID, userID);
return { user1, user2, status: undirectedStatus.KNOW_OF };
});
const updateDatas = await updateChangedUndirectedRelationships(insertRows);
inkaAuthorUnsubmitted
Done
Inline Actions

updateChangedUndirectedRelationships only updates the relationship if there was none, or the relationship status provided it greater than the one in the db. This will not be the case here, because KNOW_OF is 0-the lowest possible value. So we will not override a more meaningful relationship.

inka: `updateChangedUndirectedRelationships` only updates the relationship if there was none, or the…
tomekUnsubmitted
Not Done
Inline Actions

Makes sense, but is there an easy way of checking if the relationship doesn't need to be updated?

tomek: Makes sense, but is there an easy way of checking if the relationship doesn't need to be…
inkaAuthorUnsubmitted
Done
Inline Actions

The only thing this function does is checking if the relationship needs to be updated, and if so updates it. So I don't think it makes sense to duplicate this logic.
We discussed this offline and agreed that this code makes sense and can be left as is.

inka: The only thing this function does is checking if the relationship needs to be updated, and if…
await createUpdates(updateDatas);
} else { } else {
invariant( invariant(
false, false,
`action ${request.action} is invalid or not supported currently`, `action ${request.action} is invalid or not supported currently`,
); );
} }
await createUpdates( await createUpdates(
▲ Show 20 Lines • Show All 169 Lines • Show Last 20 Lines
View Options

services/identity/src/ddb_utils.rs

Show First 20 Lines • Show All 240 Lines • ▼ Show 20 Lines const messageDatas = userIDs.map(otherUserID => ({
creatorID: viewer.userID, creatorID: viewer.userID,
creatorFID: viewerFID, creatorFID: viewerFID,
targetID: otherUserID, targetID: otherUserID,
targetFID: request.userIDsToFID[otherUserID], targetFID: request.userIDsToFID[otherUserID],
time: now, time: now,
operation: 'farcaster_mutual', operation: 'farcaster_mutual',
})); }));
await createMessages(viewer, messageDatas, 'broadcast'); await createMessages(viewer, messageDatas, 'broadcast');
} else if (request.action === relationshipActions.ACKNOWLEDGE) {
updateIDs.push(...userIDs);
const insertRows = userIDs.map(userID => {
const [user1, user2] = sortUserIDs(viewer.userID, userID);
return { user1, user2, status: undirectedStatus.KNOW_OF };
});
const updateDatas = await updateChangedUndirectedRelationships(insertRows);
inkaAuthorUnsubmitted
Done
Inline Actions

updateChangedUndirectedRelationships only updates the relationship if there was none, or the relationship status provided it greater than the one in the db. This will not be the case here, because KNOW_OF is 0-the lowest possible value. So we will not override a more meaningful relationship.

inka: `updateChangedUndirectedRelationships` only updates the relationship if there was none, or the…
tomekUnsubmitted
Not Done
Inline Actions

Makes sense, but is there an easy way of checking if the relationship doesn't need to be updated?

tomek: Makes sense, but is there an easy way of checking if the relationship doesn't need to be…
inkaAuthorUnsubmitted
Done
Inline Actions

The only thing this function does is checking if the relationship needs to be updated, and if so updates it. So I don't think it makes sense to duplicate this logic.
We discussed this offline and agreed that this code makes sense and can be left as is.

inka: The only thing this function does is checking if the relationship needs to be updated, and if…
await createUpdates(updateDatas);
} else { } else {
invariant( invariant(
false, false,
`action ${request.action} is invalid or not supported currently`, `action ${request.action} is invalid or not supported currently`,
); );
} }
await createUpdates( await createUpdates(
▲ Show 20 Lines • Show All 169 Lines • Show Last 20 Lines