This moves ConnectionInitializationResponse, ConnectionInitializationStatus, and Heartbeat from tunnelbroker_messages into websocket_messages.
This enables usage in a planned identity_search_messages crate to avoid duplication.
Paths
| Differential D10802 Authored by will on Jan 24 2024, 12:48 PM.
Details Summary This moves ConnectionInitializationResponse, ConnectionInitializationStatus, and Heartbeat from tunnelbroker_messages into websocket_messages. This enables usage in a planned identity_search_messages crate to avoid duplication. Test Plan cargo fmt and build each affected crate
Diff Detail
Event Timelinewill held this revision as a draft. Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 24 2024, 12:48 PM2024-01-24 12:48:59 (UTC-8)
Harbormaster completed remote builds in B26126: Diff 36099.Jan 24 2024, 1:14 PM2024-01-24 13:14:54 (UTC-8) will retitled this revision from Move generic websocket messages in tunnelbroker_messages to own crate to [services] [1/n] Move generic websocket messages in tunnelbroker_messages to own crate.Jan 26 2024, 2:51 PM2024-01-26 14:51:02 (UTC-8) Comment Actions Who wrote the Tunnelbroker stuff that you're moving? Would be good to have them on the review as well Comment Actions
That would be Kamil. Just added will retitled this revision from [services] [1/n] Move generic websocket messages in tunnelbroker_messages to own crate to [identity] [1/n] Move generic websocket messages in tunnelbroker_messages to own crate.Jan 30 2024, 11:05 AM2024-01-30 11:05:00 (UTC-8) will retitled this revision from [identity] [1/n] Move generic websocket messages in tunnelbroker_messages to own crate to [shared] [1/n] Move generic websocket messages in tunnelbroker_messages to own crate. This revision is now accepted and ready to land.Jan 31 2024, 2:00 AM2024-01-31 02:00:43 (UTC-8) Closed by commit rCOMM739d8ebb85c8: [shared] [1/n] Move generic websocket messages in tunnelbroker_messages to own… (authored by will). · Explain WhyJan 31 2024, 11:10 AM2024-01-31 11:10:10 (UTC-8) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 36099 services/identity/Cargo.lock
services/tunnelbroker/Cargo.lock
shared/tunnelbroker_messages/Cargo.lock
shared/tunnelbroker_messages/Cargo.toml
shared/tunnelbroker_messages/src/messages/connection_initialization_response.rs
shared/tunnelbroker_messages/src/messages/heartbeat.rs
shared/tunnelbroker_messages/src/messages/mod.rs
|