[lib] Create a selector that checks if a user is logged in to a keyserver
ClosedPublic
Actions

Authored by tomek on Jan 26 2024, 3:22 AM.

Details

Reviewers

varun
inka
kamil

Commits

rCOMMe7ae43ad692f: [lib] Create a selector that checks if a user is logged in to a keyserver

Summary

Check if user is logged in and if the cookie exists and isn't anonymous.

Depends on D10814

Test Plan

Call a selector for keyserver with ashoatKeyserverID and check if it returns true. Add a new keyserver to the store and check if the selector returns false for it.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Jan 26 2024, 3:22 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJan 26 2024, 3:22 AM

tomek requested review of this revision.Jan 26 2024, 5:01 AM

tomek added a child revision: D10831: [lib] Run the keyserver auth only when it isn't running and a user isn't already authenticated.

Delete unnecessary check - a dependency on dataLoaded flag makes this logic invalid

inka added inline comments.Jan 26 2024, 5:44 AM

lib/selectors/user-selectors.js
175–177 ↗	(On Diff #36150)	In the next diff you use this selector, and if it returns false you retry login. But `isLoggedIn` returns false if `dataLoaded` is false. `dataLoaded` is only set to true once we connect to Ashoat's keyserver. So if the client manages to login to some other keyserver, before they log in to Ashoat's keyserver, this selector will nevertheless return false, and the handler will retry login