Page MenuHomePhabricator
Differential D9966

[keyserver] Add a function that deletes a blob
ClosedPublic
Actions

Authored by tomek on Nov 24 2023, 6:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 5, 2:20 AM
Unknown Object (File)
Wed, Oct 23, 7:24 PM
Unknown Object (File)
Wed, Oct 23, 2:49 PM
Unknown Object (File)
Oct 7 2024, 5:26 PM
Unknown Object (File)
Oct 3 2024, 11:46 PM
Unknown Object (File)
Oct 3 2024, 11:46 PM
Unknown Object (File)
Oct 3 2024, 11:46 PM
Unknown Object (File)
Oct 3 2024, 11:46 PM
View All Files
Subscribers
ashoat

Details

Reviewers
michal
bartek
rohan
Commits
rCOMM7053a0f8c5be: [keyserver] Add a function that deletes a blob
Summary

This function calls an endpoint of Blob service that deletes a blob.

Depends on D9944

Test Plan

Create a blob and delete it - check if a holder is deleted.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Nov 24 2023, 6:48 AM
Herald added a subscriber: ashoat. · View Herald TranscriptNov 24 2023, 6:48 AM
Harbormaster completed remote builds in B24387: Diff 33586.Nov 24 2023, 7:08 AM
tomek requested review of this revision.Nov 24 2023, 7:08 AM
tomek added a child revision: D9968: [keyserver] Fetch invite link blob holder.Nov 24 2023, 8:14 AM
rohan accepted this revision.Nov 24 2023, 10:42 AM
This revision is now accepted and ready to land.Nov 24 2023, 10:42 AM
tomek updated this revision to Diff 34052.Nov 30 2023, 6:52 AM

Use a param object instead of two args for hash and holder to avoid the confusion between them

Harbormaster completed remote builds in B24640: Diff 34052.Nov 30 2023, 7:11 AM
tomek updated this revision to Diff 36404.Jan 31 2024, 8:39 AM

Destructure params inside function

tomek updated this revision to Diff 36406.Jan 31 2024, 8:47 AM

Set instant flag

Harbormaster completed remote builds in B26336: Diff 36404.Jan 31 2024, 8:57 AM
Harbormaster completed remote builds in B26338: Diff 36406.Jan 31 2024, 9:05 AM
bartek accepted this revision.Feb 7 2024, 2:05 AM
bartek added inline comments.
keyserver/src/services/blob.js
103–105 ↗(On Diff #36406)

Before landing, could you update this diff to use the function from D10908?

tomek updated this revision to Diff 36846.Feb 8 2024, 6:31 AM

Use auth headers

keyserver/src/services/blob.js
103–105 ↗(On Diff #36406)

Sure!

Harbormaster completed remote builds in B26649: Diff 36846.Feb 8 2024, 6:47 AM
Closed by commit rCOMM7053a0f8c5be: [keyserver] Add a function that deletes a blob (authored by tomek). · Explain WhyFeb 14 2024, 7:58 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM7053a0f8c5be: [keyserver] Add a function that deletes a blob.

Revision Contents
Changeset List

PathSize
keyserver/
src/
services/
22 lines

Diff 36404

View Options

keyserver/src/services/blob.js

Loading...