[keyserver] Delete a holder after deleting a blob
ClosedPublic
Actions

Authored by tomek on Nov 24 2023, 8:57 AM.

Details

Reviewers

michal
bartek
rohan

Commits

rCOMM80a608e1b045: [keyserver] Delete a holder after deleting a blob

Summary

When deleting an invite link, check what was its blob holder, and schedule its deletion.

Depends on D9968

Test Plan

Delete a link and check if a holder is deleted in the Blob service. Also tested if deleting a link with an invalid holder doesn't cause any issues.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Nov 24 2023, 8:57 AM

Herald added a subscriber: ashoat. · View Herald TranscriptNov 24 2023, 8:57 AM

Harbormaster completed remote builds in B24398: Diff 33597.Nov 24 2023, 9:35 AM

tomek requested review of this revision.Nov 24 2023, 9:35 AM

bartek accepted this revision.Nov 27 2023, 1:39 AM

This revision is now accepted and ready to land.Nov 27 2023, 1:39 AM

Rebase

tomek added a child revision: D10098: [keyserver] Modify blob functions so that they take params object where both hash and holder are provided.Nov 30 2023, 7:08 AM

Harbormaster completed remote builds in B24642: Diff 34054.Nov 30 2023, 7:38 AM

Instantly delete blobs

Harbormaster completed remote builds in B26339: Diff 36407.Jan 31 2024, 9:34 AM

tomek edited the test plan for this revision. (Show Details)Feb 14 2024, 3:45 AM

Closed by commit rCOMM80a608e1b045: [keyserver] Delete a holder after deleting a blob (authored by tomek). · Explain WhyFeb 14 2024, 7:58 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM80a608e1b045: [keyserver] Delete a holder after deleting a blob.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

deleters/

link-deleters.js

13 lines

Diff 36407

View Options

keyserver/src/deleters/link-deleters.js

[keyserver] Delete a holder after deleting a blobClosedPublicActions