Details

Reviewers

michal
bartek
rohan

Commits

rCOMMe4890d882eee: [keyserver] Introduce a function that allows fetching all the primary links

Summary

Currently we're fetching only the links for communities where a viewer is a member. For the migration to work we need to be able to fetch all the links - this diff introduces a function that allows it.

Depends on D10134

Test Plan

Check if in the web app we're receiving only the links for communities where a viewer is a member.
Check if calling fetchAllPrimaryInviteLinks returns all the links.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Dec 4 2023, 4:37 AM

Herald added a subscriber: ashoat. · View Herald TranscriptDec 4 2023, 4:37 AM

Harbormaster completed remote builds in B24721: Diff 34178.Dec 4 2023, 4:56 AM

tomek requested review of this revision.Dec 4 2023, 4:56 AM

This feels pretty messy. I'm not sure what the callstack looks like, but is it possible to introduce a second function for this (with shared code factored out) instead of overloading fetchPrimaryInviteLinks to handle two different scenarios?

In D10150#295223, @ashoat wrote:

This feels pretty messy. I'm not sure what the callstack looks like, but is it possible to introduce a second function for this (with shared code factored out) instead of overloading fetchPrimaryInviteLinks to handle two different scenarios?

Yeah, I can do that. Shouldn't matter too much at the call sites.

Split a function into two

tomek edited the summary of this revision. (Show Details)Dec 4 2023, 6:47 AM

tomek edited the test plan for this revision. (Show Details)

tomek retitled this revision from [keyserver] Fetch all the links when a viewer is a script viewer to [keyserver] Introduce a function that allows fetching all the primary links.

Thank you!!

Harbormaster completed remote builds in B24728: Diff 34185.Dec 4 2023, 7:34 AM

rohan accepted this revision.Dec 5 2023, 8:24 AM

This revision is now accepted and ready to land.Dec 5 2023, 8:24 AM

tomek added a child revision: D10205: [keyserver] Add a function that synchronizes keyserver's invite links with blobs.Dec 6 2023, 6:13 AM