Page MenuHomePhabricator
Differential D11131

[lib] Add a keyserverID prop to calendar-query-handler
ClosedPublic
Actions

Authored by tomek on Feb 21 2024, 6:50 AM.
Tags
None
Referenced Files
F5247674: D11131.diff
Sun, Apr 6, 12:28 AM
Unknown Object (File)
Fri, Mar 28, 3:00 PM
Unknown Object (File)
Mon, Mar 17, 10:44 PM
Unknown Object (File)
Sun, Mar 9, 9:31 AM
Unknown Object (File)
Feb 27 2025, 2:16 AM
Unknown Object (File)
Feb 27 2025, 2:16 AM
Unknown Object (File)
Feb 25 2025, 6:38 AM
Unknown Object (File)
Feb 16 2025, 12:17 AM
View All 70 Files
Subscribers
ashoat

Details

Reviewers
inka
kamil
michal
atul
Commits
rCOMMa113da46cf5b: [lib] Add a keyserverID prop to calendar-query-handler
Summary

This component should be aware of the keyserver that should receive an updated query.

https://linear.app/comm/issue/ENG-5779/update-calendarqueryhandler

Depends on D11130

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Branch
sockets
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
socket/
4 lines
1 line

Diff 37399

View Options

lib/socket/calendar-query-handler.react.js

Show First 20 Lines • Show All 65 Lines • ▼ Show 20 Lines): Promise<RegisterResponse> {
} }
const usernameQuery = SQL` const usernameQuery = SQL`
SELECT COUNT(id) AS count SELECT COUNT(id) AS count
FROM users FROM users
WHERE LCASE(username) = LCASE(${request.username}) WHERE LCASE(username) = LCASE(${request.username})
`; `;
const promises = [dbQuery(usernameQuery)]; const promises = [dbQuery(usernameQuery)];
const { calendarQuery } = request; const { calendarQuery, publicKey, socialProof } = request;
if (calendarQuery) { if (calendarQuery) {
promises.push(verifyCalendarQueryThreadIDs(calendarQuery)); promises.push(verifyCalendarQueryThreadIDs(calendarQuery));
} }
const [[usernameResult]] = await Promise.all(promises); const [[usernameResult]] = await Promise.all(promises);
if (reservedUsernamesSet.has(request.username.toLowerCase())) { if (reservedUsernamesSet.has(request.username.toLowerCase())) {
if (hasMinCodeVersion(viewer.platformDetails, 120)) { if (hasMinCodeVersion(viewer.platformDetails, 120)) {
throw new ServerError('username_reserved'); throw new ServerError('username_reserved');
Show All 15 Lines): Promise<RegisterResponse> {
const newUserQuery = SQL` const newUserQuery = SQL`
INSERT INTO users(id, username, hash, creation_time, ethereum_address) INSERT INTO users(id, username, hash, creation_time, ethereum_address)
VALUES ${[newUserRow]} VALUES ${[newUserRow]}
`; `;
const [userViewerData] = await Promise.all([ const [userViewerData] = await Promise.all([
createNewUserCookie(id, { createNewUserCookie(id, {
platformDetails: request.platformDetails, platformDetails: request.platformDetails,
deviceToken, deviceToken,
publicKey,
socialProof,
}), }),
deleteCookie(viewer.cookieID), deleteCookie(viewer.cookieID),
dbQuery(newUserQuery), dbQuery(newUserQuery),
]); ]);
viewer.setNewCookie(userViewerData); viewer.setNewCookie(userViewerData);
if (calendarQuery) { if (calendarQuery) {
await setNewSession(viewer, calendarQuery, 0); await setNewSession(viewer, calendarQuery, 0);
} }
▲ Show 20 Lines • Show All 77 Lines • Show Last 20 Lines
View Options

lib/socket/socket.react.js

Show First 20 Lines • Show All 65 Lines • ▼ Show 20 Lines): Promise<RegisterResponse> {
} }
const usernameQuery = SQL` const usernameQuery = SQL`
SELECT COUNT(id) AS count SELECT COUNT(id) AS count
FROM users FROM users
WHERE LCASE(username) = LCASE(${request.username}) WHERE LCASE(username) = LCASE(${request.username})
`; `;
const promises = [dbQuery(usernameQuery)]; const promises = [dbQuery(usernameQuery)];
const { calendarQuery } = request; const { calendarQuery, publicKey, socialProof } = request;
if (calendarQuery) { if (calendarQuery) {
promises.push(verifyCalendarQueryThreadIDs(calendarQuery)); promises.push(verifyCalendarQueryThreadIDs(calendarQuery));
} }
const [[usernameResult]] = await Promise.all(promises); const [[usernameResult]] = await Promise.all(promises);
if (reservedUsernamesSet.has(request.username.toLowerCase())) { if (reservedUsernamesSet.has(request.username.toLowerCase())) {
if (hasMinCodeVersion(viewer.platformDetails, 120)) { if (hasMinCodeVersion(viewer.platformDetails, 120)) {
throw new ServerError('username_reserved'); throw new ServerError('username_reserved');
Show All 15 Lines): Promise<RegisterResponse> {
const newUserQuery = SQL` const newUserQuery = SQL`
INSERT INTO users(id, username, hash, creation_time, ethereum_address) INSERT INTO users(id, username, hash, creation_time, ethereum_address)
VALUES ${[newUserRow]} VALUES ${[newUserRow]}
`; `;
const [userViewerData] = await Promise.all([ const [userViewerData] = await Promise.all([
createNewUserCookie(id, { createNewUserCookie(id, {
platformDetails: request.platformDetails, platformDetails: request.platformDetails,
deviceToken, deviceToken,
publicKey,
socialProof,
}), }),
deleteCookie(viewer.cookieID), deleteCookie(viewer.cookieID),
dbQuery(newUserQuery), dbQuery(newUserQuery),
]); ]);
viewer.setNewCookie(userViewerData); viewer.setNewCookie(userViewerData);
if (calendarQuery) { if (calendarQuery) {
await setNewSession(viewer, calendarQuery, 0); await setNewSession(viewer, calendarQuery, 0);
} }
▲ Show 20 Lines • Show All 77 Lines • Show Last 20 Lines