Page MenuHomePhabricator

[web] Update existing checks on isDefault in role-actions-menu.reactjs
ClosedPublic

Authored by atul on Nov 30 2023, 1:22 PM.
Tags
None
Referenced Files
F3350461: D10119.id37460.diff
Fri, Nov 22, 10:42 PM
F3350443: D10119.id35096.diff
Fri, Nov 22, 10:35 PM
F3347094: D10119.diff
Fri, Nov 22, 11:07 AM
Unknown Object (File)
Thu, Nov 21, 3:06 AM
Unknown Object (File)
Thu, Nov 21, 3:06 AM
Unknown Object (File)
Sun, Nov 10, 11:28 PM
Unknown Object (File)
Wed, Oct 30, 11:03 PM
Unknown Object (File)
Sat, Oct 26, 10:19 PM
Subscribers

Details

Summary

We now want to make sure that we get rid of checks on role.isDefault and replace them with checks on role.specialRole:

  • For default roles, this is `role.specialRole === ${specialRoles.DEFAULT_ROLE}
  • For admin roles, this is `role.specialRole === ${specialRoles.ADMIN_ROLE}

Part of ENG-5993

This diff handles role-actions-menu.react.js

Depends on D10118

Test Plan

Confirmed the use of roleIsDefaultRole had no change on the results in the code

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rohan held this revision as a draft.
rohan published this revision for review.Nov 30 2023, 1:34 PM
This revision is now accepted and ready to land.Dec 4 2023, 12:28 AM
atul edited reviewers, added: rohan; removed: atul.