Paths

Table of Contentst

[lib] Add keyserverID to processServerRequestsActionType
ClosedPublic
Actions

Authored by tomek on Feb 27 2024, 10:12 AM.

Details

Reviewers

michal
atul
inka
kamil

Commits

rCOMM80c75e317126: [lib] Add keyserverID to processServerRequestsActionType

Summary

This is needed to correctly compute store inconsistencies - we should filter only the entities from one keyserver.

https://linear.app/comm/issue/ENG-5780/update-requestresponsehandler

Depends on D11181

Test Plan

Increase session check frequency and add a console.log in entries reducer to verify that processServerRequestsActionType payload contains keyserverID.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Feb 27 2024, 10:12 AM

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 27 2024, 10:12 AM

Harbormaster completed remote builds in B27198: Diff 37647.Feb 27 2024, 10:27 AM

tomek requested review of this revision.Feb 27 2024, 10:27 AM

tomek added a child revision: D11183: [lib] Compare only entities from one keyserver when checking the inconsistencies.Feb 27 2024, 1:23 PM

atul accepted this revision.Feb 27 2024, 9:17 PM

This revision is now accepted and ready to land.Feb 27 2024, 9:17 PM

Closed by commit rCOMM80c75e317126: [lib] Add keyserverID to processServerRequestsActionType. · Explain WhyFeb 29 2024, 3:42 PM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM80c75e317126: [lib] Add keyserverID to processServerRequestsActionType.

Revision Contents
Changeset List

Path

Size

lib/

socket/

request-response-handler.react.js

2 lines

socket.react.js

1 line

types/

request-types.js

1 line

Diff 37703

View Options

lib/socket/request-response-handler.react.js

View Options

lib/socket/socket.react.js

View Options

lib/types/request-types.js

[lib] Add keyserverID to processServerRequestsActionTypeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 37703

lib/socket/request-response-handler.react.js

lib/socket/socket.react.js

lib/types/request-types.js

[lib] Add keyserverID to processServerRequestsActionType
ClosedPublic
Actions

Revision Contents
Changeset List