Page MenuHomePhabricator
Differential D11606

[lib] Update `FarcasterDataHandler` to construct `FarcasterRelationshipRequest` with `userIDsToFID`
ClosedPublic
Actions

Authored by atul on Apr 9 2024, 8:49 PM.
Tags
None
Referenced Files
F3358681: D11606.diff
Sun, Nov 24, 5:46 AM
Unknown Object (File)
Sun, Nov 3, 9:25 AM
Unknown Object (File)
Sun, Nov 3, 9:25 AM
Unknown Object (File)
Sun, Nov 3, 9:25 AM
Unknown Object (File)
Sun, Nov 3, 9:25 AM
Unknown Object (File)
Sun, Nov 3, 9:25 AM
Unknown Object (File)
Sun, Nov 3, 9:25 AM
Unknown Object (File)
Sun, Nov 3, 9:25 AM
View All 70 Files
Subscribers
ashoat

Details

Reviewers
ginsu
varun
will
tomek
Commits
rCOMM6e98c6bfd206: [lib] Update `FarcasterDataHandler` to construct `FarcasterRelationshipRequest`…
Summary

We're updating FarcasterDataHandler to construct userIDsToFID map which will be passed to the keyserver. We include userIDs and fids for both the "target users" as well as current user.

NOTE: The request constructed on the client will currently fail. We need to update both validators and responder on keyserver to support this new format.

Depends on D11605

Test Plan

Add log statements to userIDsToFID, userIDsToFIDIncludingCurrentUser, and createThreadsAndRobotextForFarcasterMutuals and ensure that data is structured as expected.

(made some tweaks to the code here, so will go through again before landing)

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Apr 9 2024, 8:49 PM
Herald added a subscriber: ashoat. · View Herald TranscriptApr 9 2024, 8:49 PM
Harbormaster completed remote builds in B28107: Diff 38963.Apr 9 2024, 9:06 PM
atul requested review of this revision.Apr 9 2024, 9:06 PM
atul added a child revision: D11607: [keyserver] Update `createPersonalThreads` to support both `[Traditional/Farcaster]RelationshipRequest`.Apr 9 2024, 9:17 PM
tomek accepted this revision.Apr 10 2024, 6:43 AM
NOTE: The request constructed on the client will currently fail. We need to update both validators and responder on keyserver to support this new format.

A safer ordering might be to first introduce the support for a new format on the keyserver, gated behind code version, and then modify the format on the client.

lib/components/farcaster-data-handler.react.js
30
92–98

Up to you, but Object.fromEntries might be simpler.

ashoat added inline comments.Apr 10 2024, 8:47 AM
lib/components/farcaster-data-handler.react.js
24

I think we can now remove this line, and instead define loggedIn based on !!currentUserID

atul updated this revision to Diff 39001.Apr 10 2024, 12:06 PM
atul marked an inline comment as done.

address @tomek's feedback

atul added inline comments.Apr 10 2024, 12:10 PM
lib/components/farcaster-data-handler.react.js
24

Will update with this change

92–98

That's a lot cleaner and more concise, thanks for the suggestion!

atul updated this revision to Diff 39004.Apr 10 2024, 12:14 PM

address @ashoat's feedback

ginsu accepted this revision.Apr 10 2024, 12:25 PM
This revision is now accepted and ready to land.Apr 10 2024, 12:25 PM
Harbormaster completed remote builds in B28135: Diff 39001.Apr 10 2024, 12:25 PM
Harbormaster completed remote builds in B28136: Diff 39004.Apr 10 2024, 12:33 PM
atul mentioned this in D11669: [native] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages.Apr 16 2024, 12:23 PM
atul mentioned this in D11609: [lib] Narrow `TraditionalRelationshipRequest` to exclude 'farcaster' action.Apr 17 2024, 12:24 PM
atul updated this revision to Diff 39248.Apr 18 2024, 1:20 PM

rebase and land

This revision was landed with ongoing or failed builds.Apr 18 2024, 1:26 PM
Closed by commit rCOMM6e98c6bfd206: [lib] Update `FarcasterDataHandler` to construct `FarcasterRelationshipRequest`… (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM6e98c6bfd206: [lib] Update `FarcasterDataHandler` to construct `FarcasterRelationshipRequest`….
Harbormaster completed remote builds in B28307: Diff 39248.Apr 18 2024, 1:42 PM
atul mentioned this in rCOMMbf26a3ce015a: [native] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages.Apr 19 2024, 11:37 AM

Revision Contents
Changeset List

PathSize
lib/
components/
42 lines

Diff 38963

View Options

lib/components/farcaster-data-handler.react.js

Loading...