Paths

Table of Contentst

Differential D11603

[lib] Rename `sansFarcaster` variable names and types to `Traditional*`
ClosedPublic
Actions

Authored by atul on Apr 9 2024, 6:40 PM.

Tags

None

Referenced Files

	F3358376: D11603.id38997.diff
	Sun, Nov 24, 4:29 AM

	F3358372: D11603.id38959.diff
	Sun, Nov 24, 4:28 AM

	F3358060: D11603.diff
	Sun, Nov 24, 3:12 AM

	Unknown Object (File)
	Sun, Nov 3, 9:57 AM

	Unknown Object (File)
	Oct 13 2024, 12:24 AM

	Unknown Object (File)
	Oct 13 2024, 12:24 AM

	Unknown Object (File)
	Oct 13 2024, 12:24 AM

	Unknown Object (File)
	Oct 13 2024, 12:24 AM

View All 56 Files

Subscribers

Details

Reviewers

ginsu
tomek
will
varun

Commits

rCOMM5f8a4e609540: [lib] Rename `sansFarcaster` variable names and types to `Traditional*`

Summary

Including farcaster in all of these types and variables when it's often completely irrelevant doesn't make sense. Calling them Legacy* doesn't quite make sense either since they're def not being phased out, so settled on Traditional* to keep consistent with D11602

Depends on D11602

Test Plan

NA, simple rename

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Apr 9 2024, 6:40 PM

Herald added a subscriber: ashoat. · View Herald TranscriptApr 9 2024, 6:40 PM

Harbormaster completed remote builds in B28103: Diff 38959.Apr 9 2024, 6:59 PM

atul requested review of this revision.Apr 9 2024, 6:59 PM

atul added a child revision: D11604: [keyserver] Update `updateRelationshipInputValidator` to accept both traditional/farcaster requests.Apr 9 2024, 7:50 PM

atul added a child revision: D11605: [lib] Re-introduce `RelationshipRequest` and replace `TraditionalRelationshipRequest` where simple.Apr 9 2024, 8:06 PM

ginsu accepted this revision.Apr 9 2024, 10:06 PM

This revision is now accepted and ready to land.Apr 9 2024, 10:06 PM

land

This revision was landed with ongoing or failed builds.Apr 10 2024, 11:51 AM

Closed by commit rCOMM5f8a4e609540: [lib] Rename `sansFarcaster` variable names and types to `Traditional*` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM5f8a4e609540: [lib] Rename `sansFarcaster` variable names and types to `Traditional*`.

Harbormaster completed remote builds in B28133: Diff 38997.Apr 10 2024, 11:55 AM

Revision Contents
Changeset List

Path

Size

lib/

types/

relationship-types.js

8 lines

Diff 38998

lib/types/relationship-types.js

Loading...