Page MenuHomePhabricator

[lib] Narrow `TraditionalRelationshipRequest` to exclude 'farcaster' action
ClosedPublic

Authored by atul on Apr 9 2024, 9:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 3, 9:57 AM
Unknown Object (File)
Sat, Oct 26, 5:57 AM
Unknown Object (File)
Oct 13 2024, 12:24 AM
Unknown Object (File)
Oct 13 2024, 12:24 AM
Unknown Object (File)
Oct 13 2024, 12:24 AM
Unknown Object (File)
Oct 13 2024, 12:24 AM
Unknown Object (File)
Oct 13 2024, 12:24 AM
Unknown Object (File)
Oct 13 2024, 12:24 AM
Subscribers

Details

Summary

Narrow TraditionalRelationshipRequest to exclude 'farcaster' action and make necessary changes across native/web client.

Will update validators/keyserver in subsequent diffs.


Depends on D11607

Test Plan

flow + validators will be tested in subsequent diffs.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul requested review of this revision.Apr 9 2024, 9:57 PM
tomek added inline comments.
lib/hooks/relationship-prompt.js
12–13 ↗(On Diff #38967)

Can we merge these imports?

This revision is now accepted and ready to land.Apr 10 2024, 6:51 AM
lib/hooks/relationship-prompt.js
12–13 ↗(On Diff #38967)

Ah yeah, thanks for catching that

This diff is safe to land since we're just narrowing flow types on the clients. No runtime changes so this shouldn't break anything.

This revision was landed with ongoing or failed builds.Apr 18 2024, 1:26 PM
This revision was automatically updated to reflect the committed changes.