[lib] Fix `farcasterRelationshipRequestValidator`
ClosedPublic
Actions

Authored by atul on Apr 10 2024, 12:47 PM.

Details

Reviewers

ginsu
tomek
will
varun

Commits

rCOMM003bf69d1b44: [lib] Fix `farcasterRelationshipRequestValidator`

Summary

exactlyTwoDictEntriesValidator is only relevant for UpdateRelationshipMessages, not for the request. Multiple farcaster mutuals can be included in single FarcasterRelationshipRequest.

Depends on D11612

Test Plan

Able to include multiple users in single request farcaster request (hard-coded dummy FIDs in request)

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Apr 10 2024, 12:47 PM

Herald added a subscriber: ashoat. · View Herald TranscriptApr 10 2024, 12:47 PM

Harbormaster completed remote builds in B28147: Diff 39015.Apr 10 2024, 1:25 PM

atul requested review of this revision.Apr 10 2024, 1:25 PM

tomek accepted this revision.Apr 11 2024, 8:27 AM

This revision is now accepted and ready to land.Apr 11 2024, 8:27 AM

Do we need a dedicated validator for UpdateRelationshipMessage?

atul added a child revision: D11641: [lib] Split `UpdateRelationshipMessageData` into `UpdateTraditionalMessageData` and `UpdateFarcasterMessageData`.Apr 11 2024, 8:05 PM

In D11624#334284, @tomek wrote:

Do we need a dedicated validator for UpdateRelationshipMessage?

Yeah, we introduced rawUpdateFarcasterRelationshipMessageInfoValidator to handle this (has been landed). We didn't end up needing exactlyTwoDictEntriesValidator because modified type to include creatorFID and targetFID instead.