[lib] Split `UpdateRelationshipMessageData` into `UpdateTraditionalMessageData` and `UpdateFarcasterMessageData`
ClosedPublic
Actions

Authored by atul on Apr 11 2024, 8:05 PM.

Details

Reviewers

ginsu
tomek
varun
will

Commits

rCOMM702489595a59: [lib] Split `UpdateRelationshipMessageData` into `UpdateTraditionalMessageData`…

Summary

Pretty straightforward, the UpdateFarcasterMessageData variant includes creatorFID and targetFID.

Considered something like

+userIDsToFID: { +[userID: string]: string },

for consistency with FarcasterRelationshipRequest, but think this approach is cleaner and we don't need validators/etc to ensure that there are only two entries in userIDsToFID, etc.

Depends on D11624

Test Plan

flow + CI

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Apr 11 2024, 8:05 PM

Herald added a subscriber: ashoat. · View Herald TranscriptApr 11 2024, 8:05 PM

atul published this revision for review.Apr 11 2024, 8:06 PM

atul edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B28181: Diff 39070.Apr 11 2024, 8:21 PM

atul added a child revision: D11642: [lib] Split `rawUpdateRelationshipMessageInfoValidator` into `rawUpdate[Traditional/Farcaster]RelationshipMessageInfoValidator`.Apr 11 2024, 8:42 PM

tomek accepted this revision.Apr 12 2024, 2:39 AM

tomek added inline comments.

lib/types/messages/update-relationship.js
15–24

This revision is now accepted and ready to land.Apr 12 2024, 2:39 AM

atul added inline comments.Apr 17 2024, 12:37 PM

lib/types/messages/update-relationship.js
15–24	Thanks for catching this!

address @tomek's feedback

This is safe to land since we don't have equivalent to https://github.com/CommE2E/comm/commit/7024301fcda748efefa900bd952cd8e127aac87d landed on master yet so these messages aren't currently getting created.

This revision was landed with ongoing or failed builds.Apr 17 2024, 12:42 PM

Closed by commit rCOMM702489595a59: [lib] Split `UpdateRelationshipMessageData` into `UpdateTraditionalMessageData`… (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM702489595a59: [lib] Split `UpdateRelationshipMessageData` into `UpdateTraditionalMessageData`….

Harbormaster completed remote builds in B28275: Diff 39197.Apr 17 2024, 1:04 PM