Page MenuHomePhabricator

[keyserver] Update `updateRelationshipsResponder` to handle `RelationshipRequest`
ClosedPublic

Authored by atul on Apr 9 2024, 10:11 PM.
Tags
None
Referenced Files
F3394182: D11611.id38969.diff
Sat, Nov 30, 6:06 PM
F3394175: D11611.id39257.diff
Sat, Nov 30, 6:05 PM
Unknown Object (File)
Thu, Nov 28, 12:48 AM
Unknown Object (File)
Thu, Nov 28, 12:43 AM
Unknown Object (File)
Thu, Nov 28, 12:37 AM
Unknown Object (File)
Wed, Nov 27, 10:40 PM
Unknown Object (File)
Wed, Nov 20, 4:32 PM
Unknown Object (File)
Sun, Nov 3, 9:48 AM
Subscribers

Details

Summary

Make necessary changes to updateRelationshipsResponder and updateRelationships to support RelationshipRequest which is union of previous TraditionalRelationshipRequest and FarcasterRelationshipRequest.

  • Using request.action instead of destructuring makes it clear to flow in request.action === relationshipActions.FARCASTER_MUTUAL branch that request.userIDsToFID is available
  • We get userIDs using userIDsToFID if farcaster request and pass to new Set(requestUserIDs) which is the only place request.userIDs is "directly" consumed
NOTE: Will update validator in next diff.

Depends on D11610

Test Plan

Send both traditional and farcaster requests, set breakpoint in updateRelationships, ensure that values are as expected at each step.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 9 2024, 10:13 PM
Harbormaster failed remote builds in B28113: Diff 38969!
Harbormaster failed remote builds in B28114: Diff 38970!
atul requested review of this revision.Apr 10 2024, 9:54 AM
This revision is now accepted and ready to land.Apr 11 2024, 8:24 AM
This revision was landed with ongoing or failed builds.Apr 18 2024, 1:26 PM
This revision was automatically updated to reflect the committed changes.