[lib] Fix `containingThreadID` typo in `usePotentialMemberItems`
ClosedPublic
Actions

Authored by atul on May 30 2024, 8:37 PM.

Details

Reviewers

ashoat
ginsu
tomek
varun

Commits

rCOMM3e1eaaa86882: [lib] Fix `containingThreadID` typo in `usePotentialMemberItems`

Summary

Super minor, but noticed while working with usePotentialMemberItems so figured I'd fix.

Depends on D12158

Test Plan

NA, just made sure new name doesn't collide with any existing names.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.May 30 2024, 8:37 PM

atul published this revision for review.May 30 2024, 8:40 PM

Harbormaster completed remote builds in B29326: Diff 40803.May 30 2024, 8:54 PM

Thanks for fixing!

This revision is now accepted and ready to land.May 31 2024, 4:01 AM

land

This revision was landed with ongoing or failed builds.May 31 2024, 12:03 PM

Closed by commit rCOMM3e1eaaa86882: [lib] Fix `containingThreadID` typo in `usePotentialMemberItems` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM3e1eaaa86882: [lib] Fix `containingThreadID` typo in `usePotentialMemberItems`.

Harbormaster completed remote builds in B29331: Diff 40810.May 31 2024, 12:13 PM

Revision Contents
Changeset List

Path

Size

lib/

shared/

search-utils.js

8 lines

Diff 40803

View Options

lib/shared/search-utils.js

Show All 26 Lines	function useFilteredChildThreads(
threadID: string,		threadID: string,
filter?: ThreadFilter,		filter?: ThreadFilter,
): $ReadOnlyArray<ChatThreadItem> {		): $ReadOnlyArray<ChatThreadItem> {
const defaultPredicate = React.useCallback(() => true, []);		const defaultPredicate = React.useCallback(() => true, []);
const { predicate = defaultPredicate, searchText = '' } = filter ?? {};		const { predicate = defaultPredicate, searchText = '' } = filter ?? {};
const childThreads = useSelector(state => childThreadInfos(state)[threadID]);		const childThreads = useSelector(state => childThreadInfos(state)[threadID]);
const subchannelIDs = React.useMemo(() => {		const subchannelIDs = React.useMemo(() => {
if (!childThreads) {		if (!childThreads) {
return new Set();		return new Set<string>();
}		}
return new Set(		return new Set<string>(
childThreads.filter(predicate).map(threadInfo => threadInfo.id),		childThreads.filter(predicate).map(threadInfo => threadInfo.id),
);		);
}, [childThreads, predicate]);		}, [childThreads, predicate]);

const filterSubchannels = React.useCallback(		const filterSubchannels = React.useCallback(
thread => subchannelIDs.has(thread?.id),		thread => subchannelIDs.has(thread?.id),
[subchannelIDs],		[subchannelIDs],
);		);
▲ Show 20 Lines • Show All 71 Lines • Show Last 20 Lines

[lib] Fix `containingThreadID` typo in `usePotentialMemberItems`ClosedPublicActions