Page MenuHomePhabricator

[identity] Remove device data on device list update
ClosedPublic

Authored by bartek on Jun 2 2024, 11:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 2, 12:18 AM
Unknown Object (File)
Thu, Oct 10, 9:30 PM
Unknown Object (File)
Thu, Oct 10, 9:30 PM
Unknown Object (File)
Thu, Oct 10, 9:30 PM
Unknown Object (File)
Thu, Oct 10, 9:30 PM
Unknown Object (File)
Thu, Oct 10, 9:29 PM
Unknown Object (File)
Sep 23 2024, 7:47 AM
Unknown Object (File)
Sep 9 2024, 9:29 AM
Subscribers

Details

Summary

Resolves ENG-7897.
We should not rely on secondary device removing CSAT and keys on its own. This diff adds a failover mechanism,
that invalidates CSAT and removes device keys when primary device updates the device list, just in case
secondary device failed to remove it before logging out.

These calls are idempotent - they're no-op when CSAT or keys have been already removed.

Depends on D12225

Test Plan

Secondary logout flow:

  • Commented-out the LogOutSecondaryDevice RPC call
  • Confirmed that device keys were removed from DDB

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage